From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 530D610A00; Thu, 7 Dec 2023 06:50:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="CQN2dWoL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7998AC433C8; Thu, 7 Dec 2023 06:50:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1701931854; bh=pnIdKiT+bON/xCNZGUM/Uq8e1AWP7hNVCHxLJbzR0us=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CQN2dWoL36aLwsT1eLWhMsAa5I3P+sAOVlGrvLF52zU4G77OImp7uJJ2eB6xXL6d2 s8ypmac5WZ7u1/oCqxD3FKpvq/v2jDtyP9s9g2NR8E+9zOH1yF1lqNh09IOM1QmMqB pWak8HAm65qEfa87U6CALD3V9h3rbym3K4fRNy2E= Date: Thu, 7 Dec 2023 10:44:33 +0900 From: Greg KH To: Hugo Villeneuve Cc: jirislaby@kernel.org, hvilleneuve@dimonoff.com, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, stable@vger.kernel.org, Andy Shevchenko Subject: Re: [PATCH 1/7] serial: sc16is7xx: fix snprintf format specifier in sc16is7xx_regmap_name() Message-ID: <2023120748-swimming-precinct-722c@gregkh> References: <20231130191050.3165862-1-hugo@hugovil.com> <20231130191050.3165862-2-hugo@hugovil.com> Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231130191050.3165862-2-hugo@hugovil.com> On Thu, Nov 30, 2023 at 02:10:43PM -0500, Hugo Villeneuve wrote: > From: Hugo Villeneuve > > Change snprint format specifier from %d to %u since port_id is unsigned. > > Fixes: 3837a0379533 ("serial: sc16is7xx: improve regmap debugfs by using one regmap per port") > Cc: stable@vger.kernel.org # 6.1.x: 3837a03 serial: sc16is7xx: improve regmap debugfs by using one regmap per port > Suggested-by: Andy Shevchenko > Signed-off-by: Hugo Villeneuve > --- > I did not originally add a "Cc: stable" tag for commit 3837a0379533 ("serial: sc16is7xx: improve regmap debugfs by using one regmap per port") > as it was intended only to improve debugging using debugfs. But > since then, I have been able to confirm that it also fixes a long standing > bug in our system where the Tx interrupt are no longer enabled at some > point when transmitting large RS-485 paquets (> 64 bytes, which is the size > of the FIFO). I have been investigating why, but so far I haven't found the > exact cause, altough I suspect it has something to do with regmap caching. > Therefore, I have added it as a prerequisite for this patch so that it is > automatically added to the stable kernels. Looks like the 0-day test bot found problems with this, so I'll hold off on taking this patch and the rest of the series until that's fixed up with a new version of this series. thanks, greg k-h