Linux Serial subsystem development
 help / color / mirror / Atom feed
From: Lino Sanfilippo <l.sanfilippo@kunbus.com>
To: gregkh@linuxfoundation.org, jirislaby@kernel.org,
	ilpo.jarvinen@linux.intel.com
Cc: u.kleine-koenig@pengutronix.de, shawnguo@kernel.org,
	s.hauer@pengutronix.de, mcoquelin.stm32@gmail.com,
	alexandre.torgue@foss.st.com, cniedermaier@dh-electronics.com,
	hugo@hugovil.com, m.brock@vanmierlo.com,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	LinoSanfilippo@gmx.de, lukas@wunner.de, p.rosenberger@kunbus.com,
	Lino Sanfilippo <l.sanfilippo@kunbus.com>,
	stable@vger.kernel.org
Subject: [PATCH v8 2/7] serial: core: set missing supported flag for RX during TX GPIO
Date: Fri,  5 Jan 2024 15:11:48 +0100	[thread overview]
Message-ID: <20240105141153.19249-3-l.sanfilippo@kunbus.com> (raw)
In-Reply-To: <20240105141153.19249-1-l.sanfilippo@kunbus.com>

If the RS485 feature RX-during-TX is supported by means of a GPIO set the
according supported flag. Otherwise setting this feature from userspace may
not be possible, since in uart_sanitize_serial_rs485() the passed RS485
configuration is matched against the supported features and unsupported
settings are thereby removed and thus take no effect.

Cc: stable@vger.kernel.org
Fixes: 163f080eb717 ("serial: core: Add option to output RS485 RX_DURING_TX state via GPIO")
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Lino Sanfilippo <l.sanfilippo@kunbus.com>
---
 drivers/tty/serial/serial_core.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
index d155131f221d..1204102d7162 100644
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -3642,6 +3642,8 @@ int uart_get_rs485_mode(struct uart_port *port)
 	if (IS_ERR(desc))
 		return dev_err_probe(dev, PTR_ERR(desc), "Cannot get rs485-rx-during-tx-gpios\n");
 	port->rs485_rx_during_tx_gpio = desc;
+	if (port->rs485_rx_during_tx_gpio)
+		port->rs485_supported.flags |= SER_RS485_RX_DURING_TX;
 
 	return 0;
 }
-- 
2.43.0


  parent reply	other threads:[~2024-01-05 14:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-05 14:11 [PATCH v8 0/7] Fixes and improvements for RS485 Lino Sanfilippo
2024-01-05 14:11 ` [PATCH v8 1/7] serial: Do not hold the port lock when setting rx-during-tx GPIO Lino Sanfilippo
2024-01-05 14:11 ` Lino Sanfilippo [this message]
2024-01-05 14:11 ` [PATCH v8 3/7] serial: core: fix sanitizing check for RTS settings Lino Sanfilippo
2024-01-05 14:11 ` [PATCH v8 4/7] serial: core: make sure RS485 cannot be enabled when it is not supported Lino Sanfilippo
2024-01-05 14:11 ` [PATCH v8 5/7] serial: core, imx: do not set RS485 enabled if " Lino Sanfilippo
2024-01-05 14:11 ` [PATCH v8 6/7] serial: omap: do not override settings for RS485 support Lino Sanfilippo
2024-01-05 14:11 ` [PATCH v8 7/7] serial: 8250_exar: Set missing rs485_supported flag Lino Sanfilippo
2024-01-28  3:10 ` [PATCH v8 0/7] Fixes and improvements for RS485 Greg KH
2024-01-29  2:39   ` Lino Sanfilippo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240105141153.19249-3-l.sanfilippo@kunbus.com \
    --to=l.sanfilippo@kunbus.com \
    --cc=LinoSanfilippo@gmx.de \
    --cc=alexandre.torgue@foss.st.com \
    --cc=cniedermaier@dh-electronics.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hugo@hugovil.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=m.brock@vanmierlo.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=p.rosenberger@kunbus.com \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox