From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail5.25mail.st (mail5.25mail.st [74.50.62.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42340BE49; Wed, 14 Feb 2024 08:49:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.50.62.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707900582; cv=none; b=RfG4Zq/GZiO2s8BGONADmv8wSTNfutO/I+17OYoCYQhCL4n129NpAyjZdZi9TCh3X3KSakLfDgZVA+qaW+HFWaP00AAB6rMcWtvf0W00BZh9SuikDTi8tYEP/icE4SuR6i0gpjGPjvH++m2lD3ZpxZlm1Ivrg5/vpwZRSWrehts= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707900582; c=relaxed/simple; bh=0dKOTDFFev2XaGHESEFJjmbPJOyKhxlyotONPs2LaXw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pR163+LtP6er+h/gJ74hj4+keta6+dhquMjJlr4D6iIbLzxB3nIcwUC7W1cssDK7GU70jB7Zm1o0HA4OfZ5xAHjSkhJKgEnX8UCIrj+qhRLqsOBzwCo1v1pdOomkgFDv/Rhm3YNTXVpXIPEI9oJfhQI6z9ZJVOLaE6L2/c0NudY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com; spf=fail smtp.mailfrom=atomide.com; dkim=pass (2048-bit key) header.d=atomide.com header.i=@atomide.com header.b=Xokx9Rem; arc=none smtp.client-ip=74.50.62.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=atomide.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=atomide.com header.i=@atomide.com header.b="Xokx9Rem" Received: from localhost (91-158-86-216.elisa-laajakaista.fi [91.158.86.216]) by mail5.25mail.st (Postfix) with ESMTPSA id 63DE2604D9; Wed, 14 Feb 2024 08:49:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=atomide.com; s=25mailst; t=1707900579; bh=0dKOTDFFev2XaGHESEFJjmbPJOyKhxlyotONPs2LaXw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Xokx9Rem2bTGe6OoCJMTUymjnOpkhfs2wKfwa81amGnWyPQNQRUCzKghQ79kHEt9l CpEFfiyJz3ULwL/CapDajR49g0HTMOqouBlfZhccDP4pHA29Zia5FiuoPlohR/sZy7 gP1GlM6GqBspogeXJ+C5fBEjTjubpgmqstNLeeqRMWV401xJEobDtsWYZqdYU4NaQZ OlMiNgO9PaxUG6axd6ZxDKM5sXJZGU/KF9FlIgEiQLf2uUwb5xdPqv4/Qdbt0gjJN4 lEZaMyOT9oGzrAXkFKvujbegLoNSUwK5mf1KQNaOGcyT68f1NLYQWLzggMGF1092yE C+XT+uMou7/pw== Date: Wed, 14 Feb 2024 10:49:05 +0200 From: Tony Lindgren To: Andy Shevchenko Cc: Greg Kroah-Hartman , Jiri Slaby , Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , "David S . Miller" , Dhruva Gole , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , Johan Hovold , Sebastian Andrzej Siewior , Vignesh Raghavendra , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH v6 1/6] printk: Save console options for add_preferred_console_match() Message-ID: <20240214084905.GP52537@atomide.com> References: <20240213084545.40617-1-tony@atomide.com> <20240213084545.40617-2-tony@atomide.com> Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: * Andy Shevchenko [240213 16:42]: > strscpy(con->name, str, namelen); > strscpy(con->opt, opt, optlen); // not sure if emptying opt is okay The strings above now get terminated too sort with the + 1 removed, I suggest we use what we already do for brl_opt: strscpy(con->name, str, CONSOLE_NAME_MAX); strscpy(con->opt, opt, CONSOLE_OPT_MAX); Regards, Tony