From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bastien Curutchet <bastien.curutchet@bootlin.com>
Cc: Jiri Slaby <jirislaby@kernel.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
herve.codina@bootlin.com, christophercordahi@nanometrics.ca
Subject: Re: [PATCH 1/1] serial: 8250_of: Add clock_notifier
Date: Thu, 4 Apr 2024 09:50:12 +0200 [thread overview]
Message-ID: <2024040455-bungee-subsidy-f5aa@gregkh> (raw)
In-Reply-To: <20240404074450.42708-1-bastien.curutchet@bootlin.com>
On Thu, Apr 04, 2024 at 09:44:50AM +0200, Bastien Curutchet wrote:
> The UART's input clock rate can change at runtime but this is not
> handled by the driver.
>
> Add a clock_notifier callback that updates the divisors when the input
> clock is updated. The serial8250_update_uartclk() is used to do so.
> PRE_RATE_CHANGE and ABORT_RATE_CHANGE notifications are ignored, only
> the POST_RATE_CHANGE is used.
Why just this one notification? You say they are ignored but do not say
why.
>
> Reorder the #include to match alphabetic order.
That is not needed here, why do that now? And "alphabetic order" is not
an issue for tty drivers, no need to do that, but if you really want to,
a separate patch series is good for that.
thanks,
greg k-h
next prev parent reply other threads:[~2024-04-04 7:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 7:44 [PATCH 1/1] serial: 8250_of: Add clock_notifier Bastien Curutchet
2024-04-04 7:50 ` Greg Kroah-Hartman [this message]
2024-04-04 8:50 ` Bastien Curutchet
2024-04-04 8:34 ` Herve Codina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024040455-bungee-subsidy-f5aa@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=bastien.curutchet@bootlin.com \
--cc=christophercordahi@nanometrics.ca \
--cc=herve.codina@bootlin.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox