From: Herve Codina <herve.codina@bootlin.com>
To: Bastien Curutchet <bastien.curutchet@bootlin.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
christophercordahi@nanometrics.ca
Subject: Re: [PATCH v2 1/1] serial: 8250_of: Add clock_notifier
Date: Fri, 5 Apr 2024 14:46:11 +0200 [thread overview]
Message-ID: <20240405144611.4b741c63@bootlin.com> (raw)
In-Reply-To: <20240405120552.35991-1-bastien.curutchet@bootlin.com>
Hi Bastien,
On Fri, 5 Apr 2024 14:05:52 +0200
Bastien Curutchet <bastien.curutchet@bootlin.com> wrote:
> The UART's input clock rate can change at runtime but this is not
> handled by the driver.
>
> Add a clock_notifier callback that updates the divisors when the input
> clock is updated. The serial8250_update_uartclk() is used to do so.
> PRE_RATE_CHANGE and ABORT_RATE_CHANGE notifications are ignored, only
> the POST_RATE_CHANGE is used. Not using PRE_RATE_CHANGE notification can
> result in a few corrupted bytes during frequency transitions but, IMHO,
> it can be acceptable in many use cases.
>
> It has been tested on a DAVINCI/OMAP-L138 processor.
>
> Signed-off-by: Bastien Curutchet <bastien.curutchet@bootlin.com>
Reviewed-by: Herve Codina <herve.codina@bootlin.com>
Best regards,
Hervé
prev parent reply other threads:[~2024-04-05 12:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 12:05 [PATCH v2 1/1] serial: 8250_of: Add clock_notifier Bastien Curutchet
2024-04-05 12:46 ` Herve Codina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240405144611.4b741c63@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=bastien.curutchet@bootlin.com \
--cc=christophercordahi@nanometrics.ca \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).