From: Roman Storozhenko <romeusmeister@gmail.com>
To: gregkh@linuxfoundation.org
Cc: jirislaby@kernel.org, Julia.Lawall@inria.fr,
skhan@linuxfoundation.org, javier.carrasco.cruz@gmail.com,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Roman Storozhenko <romeusmeister@gmail.com>
Subject: [PATCH] sysrq: Auto release device node using __free attribute
Date: Thu, 11 Apr 2024 20:02:56 +0200 [thread overview]
Message-ID: <20240411180256.61001-1-romeusmeister@gmail.com> (raw)
Add a cleanup function attribute '__free(device_node)' to the device node
pointer initialization statement and remove the pairing cleanup function
call of 'of_node_put' at the end of the function.
The '_free()' attrubute is introduced by scope-based resource management
in-kernel framework implemented in 'cleanup.h'. A pointer marked with
'__free()' attribute makes a compiler insert a cleanup function call
to the places where the pointer goes out of the scope. This feature
allows to get rid of manual cleanup function calls.
Suggested-by: Julia.Lawall <Julia.Lawall@inria.fr>
Signed-off-by: Roman Storozhenko <romeusmeister@gmail.com>
---
This patch targets the next tree:
tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
tag: next-20240411
---
drivers/tty/sysrq.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c
index 02217e3c916b..1d1261f618c0 100644
--- a/drivers/tty/sysrq.c
+++ b/drivers/tty/sysrq.c
@@ -758,11 +758,12 @@ static void sysrq_detect_reset_sequence(struct sysrq_state *state,
static void sysrq_of_get_keyreset_config(void)
{
u32 key;
- struct device_node *np;
struct property *prop;
const __be32 *p;
- np = of_find_node_by_path("/chosen/linux,sysrq-reset-seq");
+ struct device_node *np __free(device_node) =
+ of_find_node_by_path("/chosen/linux,sysrq-reset-seq");
+
if (!np) {
pr_debug("No sysrq node found");
return;
@@ -781,8 +782,6 @@ static void sysrq_of_get_keyreset_config(void)
/* Get reset timeout if any. */
of_property_read_u32(np, "timeout-ms", &sysrq_reset_downtime_ms);
-
- of_node_put(np);
}
#else
static void sysrq_of_get_keyreset_config(void)
--
2.34.1
next reply other threads:[~2024-04-11 18:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 18:02 Roman Storozhenko [this message]
2024-04-11 18:10 ` [PATCH] sysrq: Auto release device node using __free attribute Greg KH
2024-04-11 18:25 ` Roman Storozhenko
2024-04-12 5:22 ` Greg KH
2024-04-11 18:11 ` Greg KH
2024-04-11 18:17 ` Julia Lawall
2024-04-12 5:22 ` Greg KH
2024-04-12 6:21 ` Julia Lawall
2024-04-13 19:15 ` Julia Lawall
2024-04-11 18:28 ` Roman Storozhenko
2024-04-12 5:20 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240411180256.61001-1-romeusmeister@gmail.com \
--to=romeusmeister@gmail.com \
--cc=Julia.Lawall@inria.fr \
--cc=gregkh@linuxfoundation.org \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox