public inbox for linux-serial@vger.kernel.org
 help / color / mirror / Atom feed
From: Konstantin Pugin <rilian.la.te@ya.ru>
Cc: "Konstantin Pugin" <ria.freelander@gmail.com>,
	"Vladimir Zapolskiy" <vz@mleia.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Jiri Slaby" <jirislaby@kernel.org>,
	"Hugo Villeneuve" <hvilleneuve@dimonoff.com>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Lech Perczak" <lech.perczak@camlingroup.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: [PATCH v3 1/3] serial: sc16is7xx: announce support of SER_RS485_RTS_ON_SEND
Date: Thu, 18 Apr 2024 20:06:05 +0300	[thread overview]
Message-ID: <20240418170610.759838-2-rilian.la.te@ya.ru> (raw)
In-Reply-To: <20240418170610.759838-1-rilian.la.te@ya.ru>

From: Konstantin Pugin <ria.freelander@gmail.com>

The hardware supports both RTS_ON_SEND and RTS_AFTER_SEND modes, but
after the commit 4afeced55baa ("serial: core: fix sanitizing check for
RTS settings") we always end up with SER_RS485_RTS_AFTER_SEND and
always write in the register field SC16IS7XX_EFCR_RTS_INVERT_BIT, which
breaks some hardware using these chips.

Fixes: 267913ecf737 ("serial: sc16is7xx: Fill in rs485_supported")
Reviewed-by: Vladimir Zapolskiy <vz@mleia.com>
Signed-off-by: Konstantin Pugin <ria.freelander@gmail.com>
---
 drivers/tty/serial/sc16is7xx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
index 929206a9a6e1..a300eebf1401 100644
--- a/drivers/tty/serial/sc16is7xx.c
+++ b/drivers/tty/serial/sc16is7xx.c
@@ -1458,7 +1458,7 @@ static int sc16is7xx_setup_mctrl_ports(struct sc16is7xx_port *s,
 }
 
 static const struct serial_rs485 sc16is7xx_rs485_supported = {
-	.flags = SER_RS485_ENABLED | SER_RS485_RTS_AFTER_SEND,
+	.flags = SER_RS485_ENABLED | SER_RS485_RTS_ON_SEND | SER_RS485_RTS_AFTER_SEND,
 	.delay_rts_before_send = 1,
 	.delay_rts_after_send = 1,	/* Not supported but keep returning -EINVAL */
 };
-- 
2.34.1


  reply	other threads:[~2024-04-18 17:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-18 17:06 [PATCH v3 0/3] add support for EXAR XR20M1172 UART Konstantin Pugin
2024-04-18 17:06 ` Konstantin Pugin [this message]
2024-04-18 17:37   ` [PATCH v3 1/3] serial: sc16is7xx: announce support of SER_RS485_RTS_ON_SEND Andy Shevchenko
     [not found]     ` <CAF1WSuyauXes-RncLqRrYYaeP1KaDyfG82YcAaa8gK_mFUWCHg@mail.gmail.com>
2024-04-18 17:58       ` Andy Shevchenko
2024-04-18 17:06 ` [PATCH v3 2/3] dt-bindings: sc16is7xx: Add compatible line for XR20M1172 UART Konstantin Pugin
2024-04-18 17:06 ` [PATCH v3 3/3] serial: sc16is7xx: add support for EXAR " Konstantin Pugin
2024-04-18 17:54   ` Andy Shevchenko
2024-04-19  6:42   ` Jiri Slaby
2024-04-19  6:45   ` Jiri Slaby
2024-04-18 17:56 ` [PATCH v3 0/3] " Andy Shevchenko
2024-04-19 10:05 ` Maarten Brock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240418170610.759838-2-rilian.la.te@ya.ru \
    --to=rilian.la.te@ya.ru \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hvilleneuve@dimonoff.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jirislaby@kernel.org \
    --cc=lech.perczak@camlingroup.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=ria.freelander@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=vz@mleia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox