From: Parker Newman <parker@finest.io>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Parker Newman <pnewman@connecttech.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [PATCH v1 00/13] serial: 8250_exar: Clean up the driver
Date: Thu, 2 May 2024 13:49:49 -0400 [thread overview]
Message-ID: <20240502134949.5e780635@SWDEV2.connecttech.local> (raw)
In-Reply-To: <ZjPL5z7ah-Qkct6l@smile.fi.intel.com>
On Thu, 2 May 2024 20:22:47 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Thu, May 02, 2024 at 12:08:40PM -0400, Parker Newman wrote:
> > On Thu, 2 May 2024 19:01:01 +0300
> > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > > On Thu, May 02, 2024 at 11:46:45AM -0400, Parker Newman wrote:
> > > > On Thu, 2 May 2024 17:43:54 +0300
> > > > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > > >
> > > > > After a rework for CONNTECH was done, the driver may need a bit of
> > > > > love in order to become less verbose (in terms of indentation and
> > > > > code duplication) and hence easier to read.
> > > > >
> > > > > This clean up series fixes a couple of (not so critical) issues and
> > > > > cleans up the recently added code. No functional change indented by
> > > > > the cleaning up part.
> > > >
> > > > Just an FYI I submitted a patch series that fixed several of these issues but I
> > > > think it fell through the cracks (I know everyone is very busy!).
> > > >
> > > > Link: https://lore.kernel.org/linux-serial/cover.1713533298.git.pnewman@connecttech.com/
> > > >
> > > > I believe my previous patch series is no longer required. This one fixes
> > > > everything.
> > >
> > > I haven't noticed that, if it contains duplicated patches, I may replace mine
> > > with yours if you insist.
> > >
> > > In any case it's better to reply there that you prefer this series to be
> > > applied, so Greg will not pick it up.
> > >
> >
> > I do not have a preference. I am fine with using yours if it is easier on
> > the maintainers.
>
> Up to you, there is no issue to take your patches in case they are the same
> (or quite similar) as mine. I can pick them up, just tell me if you want this
> to happen with a list of the patches (as mail Message-Id).
>
Just use yours.
Thanks,
Parker
> > I will send a reply on my previous series that it is not needed and link
> > to this. I am new to the mailing lists so I didn't know what the procedure
> > is for this situation.
>
> It's not about mailing lists, it's just a common sense.
>
> > Thanks for the fixes :),
>
> You are welcome!
>
next prev parent reply other threads:[~2024-05-02 17:49 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 14:43 [PATCH v1 00/13] serial: 8250_exar: Clean up the driver Andy Shevchenko
2024-05-02 14:43 ` [PATCH v1 01/13] serial: 8250_exar: Don't return positive values as error codes Andy Shevchenko
2024-05-02 14:43 ` [PATCH v1 02/13] serial: 8250_exar: Describe all parameters in kernel doc Andy Shevchenko
2024-05-02 14:43 ` [PATCH v1 03/13] serial: 8250_exar: Kill CTI_PCI_DEVICE() Andy Shevchenko
2024-05-02 15:13 ` Parker Newman
2024-05-02 15:29 ` Andy Shevchenko
2024-05-02 15:36 ` Parker Newman
2024-05-02 15:43 ` Andy Shevchenko
2024-05-02 15:54 ` Parker Newman
2024-05-02 15:59 ` Andy Shevchenko
2024-05-02 14:43 ` [PATCH v1 04/13] serial: 8250_exar: Use PCI_SUBVENDOR_ID_IBM for subvendor ID Andy Shevchenko
2024-05-02 14:43 ` [PATCH v1 05/13] serial: 8250_exar: Trivia typo fixes Andy Shevchenko
2024-05-02 14:44 ` [PATCH v1 06/13] serial: 8250_exar: Extract cti_board_init_osc_freq() helper Andy Shevchenko
2024-05-02 14:44 ` [PATCH v1 07/13] serial: 8250_exar: Kill unneeded ->board_init() Andy Shevchenko
2024-05-02 14:44 ` [PATCH v1 08/13] serial: 8250_exar: Decrease indentation level Andy Shevchenko
2024-05-02 14:44 ` [PATCH v1 09/13] serial: 8250_exar: Return directly from switch-cases Andy Shevchenko
2024-05-02 14:44 ` [PATCH v1 10/13] serial: 8250_exar: Switch to use dev_err_probe() Andy Shevchenko
2024-05-02 14:44 ` [PATCH v1 11/13] serial: 8250_exar: Use BIT() in exar_ee_read() Andy Shevchenko
2024-05-02 16:08 ` Ilpo Järvinen
2024-05-02 17:20 ` Andy Shevchenko
2024-05-03 14:26 ` Parker Newman
2024-05-03 15:35 ` Andy Shevchenko
2024-05-03 18:56 ` Parker Newman
2024-05-06 8:37 ` Andy Shevchenko
2024-05-02 14:44 ` [PATCH v1 12/13] serial: 8250_exar: Make type of bit the same in exar_ee_*_bit() Andy Shevchenko
2024-05-02 14:44 ` [PATCH v1 13/13] serial: 8250_exar: Keep the includes sorted Andy Shevchenko
2024-05-02 15:46 ` [PATCH v1 00/13] serial: 8250_exar: Clean up the driver Parker Newman
2024-05-02 16:01 ` Andy Shevchenko
2024-05-02 16:08 ` Parker Newman
2024-05-02 17:22 ` Andy Shevchenko
2024-05-02 17:49 ` Parker Newman [this message]
2024-05-02 18:01 ` Andy Shevchenko
2024-05-03 12:36 ` Parker Newman
2024-05-03 14:47 ` Parker Newman
2024-05-03 15:33 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240502134949.5e780635@SWDEV2.connecttech.local \
--to=parker@finest.io \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pnewman@connecttech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).