From: Tony Lindgren <tony.lindgren@linux.intel.com>
To: Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
John Ogness <john.ogness@linutronix.de>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Tony Lindgren <tony@atomide.com>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
linux-serial@vger.kernel.org,
"Tony Lindgren" <tony.lindgren@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] Revert "printk: Flag register_console() if console is set on command line"
Date: Thu, 6 Jun 2024 14:41:47 +0300 [thread overview]
Message-ID: <20240606114149.118633-2-tony.lindgren@linux.intel.com> (raw)
In-Reply-To: <20240606114149.118633-1-tony.lindgren@linux.intel.com>
This reverts commit b73c9cbe4f1fc02645228aa575998dd54067f8ef.
There is no need for this change now that we are reserving console_cmdline
slots for the DEVNAME:0.0 style consoles.
Signed-off-by: Tony Lindgren <tony.lindgren@linux.intel.com>
---
kernel/printk/printk.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index 52bdd7dcdb6f..8b746eeb77fa 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -2541,9 +2541,6 @@ static int __init console_setup(char *str)
if (console_opt_save(str, brl_options))
return 1;
- /* Flag register_console() to not call try_enable_default_console() */
- console_set_on_cmdline = 1;
-
/* Don't attempt to parse a DEVNAME:0.0 style console */
if (strchr(str, ':')) {
reserve_deferred_console(str);
@@ -3578,7 +3575,7 @@ void register_console(struct console *newcon)
* Note that a console with tty binding will have CON_CONSDEV
* flag set and will be first in the list.
*/
- if (preferred_console < 0 && !console_set_on_cmdline) {
+ if (preferred_console < 0) {
if (hlist_empty(&console_list) || !console_first()->device ||
console_first()->flags & CON_BOOT) {
try_enable_default_console(newcon);
--
2.45.2
next prev parent reply other threads:[~2024-06-06 11:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 11:41 [PATCH 1/2] printk: Track command line console positions to fix console order Tony Lindgren
2024-06-06 11:41 ` Tony Lindgren [this message]
2024-06-11 8:17 ` Petr Mladek
2024-06-11 9:56 ` Tony Lindgren
2024-06-11 13:10 ` Andy Shevchenko
2024-06-11 14:01 ` Tony Lindgren
2024-06-12 14:48 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240606114149.118633-2-tony.lindgren@linux.intel.com \
--to=tony.lindgren@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).