From: Rob Herring <robh@kernel.org>
To: Animesh Agarwal <animeshagarwal28@gmail.com>
Cc: Daniel Baluta <daniel.baluta@nxp.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Hugo Villeneuve <hvilleneuve@dimonoff.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: serial: nxp,sc16is7xx: Add missing child node
Date: Wed, 12 Jun 2024 12:09:02 -0600 [thread overview]
Message-ID: <20240612180902.GA3178463-robh@kernel.org> (raw)
In-Reply-To: <20240612165457.103575-1-animeshagarwal28@gmail.com>
On Wed, Jun 12, 2024 at 10:24:55PM +0530, Animesh Agarwal wrote:
> Add missing child node property clock-sc16is7xx to nxp,sc16is7xx.yaml. This
> fixes the following warning upon running make dtbs_check:
>
> ./arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dtb: serial@0:
> Unevaluated properties are not allowed ('clock-sc16is7xx' was unexpected)
> from schema $id: http://devicetree.org/schemas/serial/nxp,sc16is7xx.yaml#
That's a pretty odd case. Lots of devices can a crystal and this is not
how we describe it. I think the clock node should just be moved out of
this node to the top level to fix this.
Ideally, when the schema was converted, the warnings from it were looked
at and were either fixed in the schema on conversion (with notes in
commit msg) or the warnings were left as to be fixed in the .dts files.
BTW, dtbs_check is run on every schema patch for the schema in the
patch. Results are here[1].
Rob
[1] https://patchwork.ozlabs.org/project/devicetree-bindings/list/
prev parent reply other threads:[~2024-06-12 18:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 16:54 [PATCH] dt-bindings: serial: nxp,sc16is7xx: Add missing child node Animesh Agarwal
2024-06-12 18:09 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240612180902.GA3178463-robh@kernel.org \
--to=robh@kernel.org \
--cc=animeshagarwal28@gmail.com \
--cc=conor+dt@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hvilleneuve@dimonoff.com \
--cc=jirislaby@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).