[PATCH] dt-bindings: serial: nxp,sc16is7xx: Add missing child node

[PATCH] dt-bindings: serial: nxp,sc16is7xx: Add missing child node

[Animesh Agarwal]

Add missing child node property clock-sc16is7xx to nxp,sc16is7xx.yaml. This
fixes the following warning upon running make dtbs_check:

./arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dtb: serial@0:
Unevaluated properties are not allowed ('clock-sc16is7xx' was unexpected)
from schema $id: http://devicetree.org/schemas/serial/nxp,sc16is7xx.yaml#

Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
Cc: Daniel Baluta <daniel.baluta@nxp.com>
---
 .../bindings/serial/nxp,sc16is7xx.yaml        | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml
index 5dec15b7e7c3..d572b7e76c39 100644
--- a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml
+++ b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml
@@ -70,6 +70,25 @@ properties:
       minimum: 0
       maximum: 1
 
+  clock-sc16is7xx:
+    type: object
+
+    additionalProperties: false
+
+    properties:
+      compatible:
+        const: fixed-clock
+
+      "#clock-cells":
+        const: 0
+
+      clock-frequency: true
+
+    required:
+      - compatible
+      - "#clock-cells"
+      - clock-frequency
+
 required:
   - compatible
   - reg
-- 
2.45.2

Re: [PATCH] dt-bindings: serial: nxp,sc16is7xx: Add missing child node

[Rob Herring]

On Wed, Jun 12, 2024 at 10:24:55PM +0530, Animesh Agarwal wrote:
> Add missing child node property clock-sc16is7xx to nxp,sc16is7xx.yaml. This
> fixes the following warning upon running make dtbs_check:
> 
> ./arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dtb: serial@0:
> Unevaluated properties are not allowed ('clock-sc16is7xx' was unexpected)
> from schema $id: http://devicetree.org/schemas/serial/nxp,sc16is7xx.yaml#

That's a pretty odd case. Lots of devices can a crystal and this is not 
how we describe it. I think the clock node should just be moved out of 
this node to the top level to fix this.

Ideally, when the schema was converted, the warnings from it were looked 
at and were either fixed in the schema on conversion (with notes in 
commit msg) or the warnings were left as to be fixed in the .dts files. 

BTW, dtbs_check is run on every schema patch for the schema in the 
patch. Results are here[1].

Rob

[1] https://patchwork.ozlabs.org/project/devicetree-bindings/list/