From: Greg KH <gregkh@linuxfoundation.org>
To: Jacky Huang <ychuang570808@gmail.com>
Cc: dan.carpenter@linaro.org, jirislaby@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Jacky Huang <ychuang3@nuvoton.com>
Subject: Re: [PATCH v2] tty: serial: ma35d1: Add a NULL check for of_node
Date: Mon, 24 Jun 2024 15:37:29 +0200 [thread overview]
Message-ID: <2024062404-avoid-grieving-a3fa@gregkh> (raw)
In-Reply-To: <20240614054554.80-1-ychuang570808@gmail.com>
On Fri, Jun 14, 2024 at 05:45:54AM +0000, Jacky Huang wrote:
> From: Jacky Huang <ychuang3@nuvoton.com>
>
> The pdev->dev.of_node can be NULL if the "serial" node is absent.
> Add a NULL check to return an error in such cases.
>
> Fixes: 930cbf92db01 ("tty: serial: Add Nuvoton ma35d1 serial driver support")
> Signed-off-by: Jacky Huang <ychuang3@nuvoton.com>
You forgot a "Reported-by:" line as Dan did report this to you.
> ---
> drivers/tty/serial/ma35d1_serial.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
Also, no info as to what changed from v1 :(
thanks,
greg k-h
next prev parent reply other threads:[~2024-06-24 13:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 5:45 [PATCH v2] tty: serial: ma35d1: Add a NULL check for of_node Jacky Huang
2024-06-24 13:37 ` Greg KH [this message]
2024-06-25 0:16 ` Jacky Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024062404-avoid-grieving-a3fa@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@linaro.org \
--cc=jirislaby@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=ychuang3@nuvoton.com \
--cc=ychuang570808@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).