From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Petr Mladek <pmladek@suse.com>
Cc: "Tony Lindgren" <tony.lindgren@linux.intel.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Steven Rostedt" <rostedt@goodmis.org>,
"John Ogness" <john.ogness@linutronix.de>,
"Sergey Senozhatsky" <senozhatsky@chromium.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
linux-serial@vger.kernel.org, "Dhruva Gole" <d-gole@ti.com>,
"Sebastian Reichel" <sre@kernel.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] printk: Add match_devname_and_update_preferred_console()
Date: Thu, 4 Jul 2024 14:57:07 +0200 [thread overview]
Message-ID: <2024070446-shuffling-maimed-85eb@gregkh> (raw)
In-Reply-To: <ZoaLA5IVTnh0E0QI@pathway.suse.cz>
On Thu, Jul 04, 2024 at 01:44:03PM +0200, Petr Mladek wrote:
> On Wed 2024-07-03 13:06:08, Tony Lindgren wrote:
> > Let's add match_devname_and_update_preferred_console() for driver
> > subsystems to call during init when the console is ready, and it's
> > character device name is known. For now, we use it only for the serial
> > layer to allow console=DEVNAME:0.0 style hardware based addressing for
> > consoles.
> >
> > The earlier attempt on doing this caused a regression with the kernel
> > command line console order as it added calling __add_preferred_console()
> > again later on during init. A better approach was suggested by Petr where
> > we add the deferred console to the console_cmdline[] and update it later
> > on when the console is ready.
> >
> > Suggested-by: Petr Mladek <pmladek@suse.com>
> > Co-developed-by: Petr Mladek <pmladek@suse.com>
> > Signed-off-by: Tony Lindgren <tony.lindgren@linux.intel.com>
>
> Reviewed-by: Petr Mladek <pmladek@suse.com>
Thanks for the review, I'll take this through the tty tree now.
greg k-h
next prev parent reply other threads:[~2024-07-04 12:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 10:06 [PATCH 0/3] Add back DEVNAME:0.0 console handling Tony Lindgren
2024-07-03 10:06 ` [PATCH 1/3] printk: Add match_devname_and_update_preferred_console() Tony Lindgren
2024-07-04 11:44 ` Petr Mladek
2024-07-04 12:57 ` Greg Kroah-Hartman [this message]
2024-07-03 10:06 ` [PATCH 2/3] serial: core: Add serial_base_match_and_update_preferred_console() Tony Lindgren
2024-07-03 10:06 ` [PATCH 3/3] Documentation: kernel-parameters: Add DEVNAME:0.0 format for serial ports Tony Lindgren
2024-07-04 11:44 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024070446-shuffling-maimed-85eb@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=corbet@lwn.net \
--cc=d-gole@ti.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=sre@kernel.org \
--cc=tony.lindgren@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).