Re: [PATCH net-next 2/2] appletalk: tashtalk: Add LocalTalk line discipline driver for AppleTalk using a TashTalk adapter

Rodolfo Zitellini
2024-08-19T12:43:10Z

> On August 19, 2024, at 11:44 AM, Arnd Bergmann <arnd@arndb.de <mailto:arnd@arndb.de>> wrote:
> Nice to see you got this into a working state! I vaguely
> remember discussing this in the past, and suggesting you
> try a user space solution,

Hi Arnd, Simon and Jiri,
First and foremost, thank you so much for taking the time to review my code
and for providing your comments.
I will do my best to address the issues and improve the code for the
next submission.

I will also add a longer description on why I went this route, it is mostly
due to compatibility with existing distributions of netatalk 2, which can
work without modification.

> As we discussed in the past, I think this really should
> not use ndo_do_ioctl(), which instead should just disappear.

I will fix this in the next revision, I was not sure if I should touch the
appletalk code for my first submission, but I can add a third patch that
takes care of this.

Kind Regards,
Rodolfo