[PATCH v1 1/1] serial: 8250_exar: Group CTI EEPROM offsets by device

[PATCH v1 1/1] serial: 8250_exar: Group CTI EEPROM offsets by device

[Andy Shevchenko]

It's not obvious from the first glance that the list of the CTI EEPROM
offsets covers three different models, let's group them accordingly for
better readability.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---

Parker, feel free to append this one to your v3 as a last patch.

 drivers/tty/serial/8250/8250_exar.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c
index b7a75db15249..072eb2bff01a 100644
--- a/drivers/tty/serial/8250/8250_exar.c
+++ b/drivers/tty/serial/8250/8250_exar.c
@@ -179,11 +179,13 @@
 
 /* CTI EEPROM offsets */
 #define CTI_EE_OFF_XR17C15X_OSC_FREQ	0x04  /* 2 words */
-#define CTI_EE_OFF_XR17V25X_OSC_FREQ	0x08  /* 2 words */
 #define CTI_EE_OFF_XR17C15X_PART_NUM	0x0A  /* 4 words */
-#define CTI_EE_OFF_XR17V25X_PART_NUM	0x0E  /* 4 words */
 #define CTI_EE_OFF_XR17C15X_SERIAL_NUM	0x0E  /* 1 word */
+
+#define CTI_EE_OFF_XR17V25X_OSC_FREQ	0x08  /* 2 words */
+#define CTI_EE_OFF_XR17V25X_PART_NUM	0x0E  /* 4 words */
 #define CTI_EE_OFF_XR17V25X_SERIAL_NUM	0x12  /* 1 word */
+
 #define CTI_EE_OFF_XR17V35X_SERIAL_NUM	0x11  /* 2 word */
 #define CTI_EE_OFF_XR17V35X_BRD_FLAGS	0x13  /* 1 word */
 #define CTI_EE_OFF_XR17V35X_PORT_FLAGS	0x14  /* 1 word */
-- 
2.43.0.rc1.1336.g36b5255a03ac

Re: [PATCH v1 1/1] serial: 8250_exar: Group CTI EEPROM offsets by device

[Andy Shevchenko]

On Fri, Sep 20, 2024 at 06:43:24PM +0300, Andy Shevchenko wrote:
> It's not obvious from the first glance that the list of the CTI EEPROM
> offsets covers three different models, let's group them accordingly for
> better readability.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> 
> Parker, feel free to append this one to your v3 as a last patch.

A bit more hints for usage of `b4`. As I described earlier you may use b4
to gather the tags, but also to inject / append other patches to the series.

Like with this one, after you collected yours, just run

	b4 am -s $<message ID of this email thread>

followed by

	git am ...

as the tool hints you. It will take care about everything you need.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 1/1] serial: 8250_exar: Group CTI EEPROM offsets by device

[Parker Newman]

On Fri, 20 Sep 2024 18:49:18 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> On Fri, Sep 20, 2024 at 06:43:24PM +0300, Andy Shevchenko wrote:
> > It's not obvious from the first glance that the list of the CTI EEPROM
> > offsets covers three different models, let's group them accordingly for
> > better readability.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >
> > Parker, feel free to append this one to your v3 as a last patch.
>

Will do.

> A bit more hints for usage of `b4`. As I described earlier you may use b4
> to gather the tags, but also to inject / append other patches to the series.
>
> Like with this one, after you collected yours, just run
>
> 	b4 am -s $<message ID of this email thread>
>
> followed by
>
> 	git am ...
>
> as the tool hints you. It will take care about everything you need.
>

Thanks again for the tips!
-Parker