Linux Serial subsystem development
 help / color / mirror / Atom feed
From: Johan Hovold <johan+linaro@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Douglas Anderson <dianders@chromium.org>,
	Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-serial@vger.kernel.org,
	Johan Hovold <johan+linaro@kernel.org>
Subject: [PATCH v3 7/9] serial: qcom-geni: drop flip buffer WARN()
Date: Wed,  9 Oct 2024 16:51:08 +0200	[thread overview]
Message-ID: <20241009145110.16847-8-johan+linaro@kernel.org> (raw)
In-Reply-To: <20241009145110.16847-1-johan+linaro@kernel.org>

Drop the unnecessary WARN() in case the TTY buffers are ever full in
favour of a rate limited dev_err() which doesn't kill the machine when
panic_on_warn is set.

Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 drivers/tty/serial/qcom_geni_serial.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
index 6c4349ea5720..22e468065666 100644
--- a/drivers/tty/serial/qcom_geni_serial.c
+++ b/drivers/tty/serial/qcom_geni_serial.c
@@ -588,9 +588,8 @@ static void handle_rx_uart(struct uart_port *uport, u32 bytes, bool drop)
 
 	ret = tty_insert_flip_string(tport, port->rx_buf, bytes);
 	if (ret != bytes) {
-		dev_err(uport->dev, "%s:Unable to push data ret %d_bytes %d\n",
-				__func__, ret, bytes);
-		WARN_ON_ONCE(1);
+		dev_err_ratelimited(uport->dev, "failed to push data (%d < %u)\n",
+				ret, bytes);
 	}
 	uport->icount.rx += ret;
 	tty_flip_buffer_push(tport);
-- 
2.45.2


  parent reply	other threads:[~2024-10-09 14:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-09 14:51 [PATCH v3 0/9] serial: qcom-geni: fix receiver enable Johan Hovold
2024-10-09 14:51 ` [PATCH v3 1/9] serial: qcom-geni: fix polled console initialisation Johan Hovold
2024-10-10 22:36   ` Doug Anderson
2024-10-09 14:51 ` [PATCH v3 2/9] serial: qcom-geni: revert broken hibernation support Johan Hovold
2024-10-09 14:51 ` [PATCH v3 3/9] serial: qcom-geni: fix shutdown race Johan Hovold
2024-10-10 22:36   ` Doug Anderson
2024-10-11  6:54     ` Johan Hovold
2024-10-09 14:51 ` [PATCH v3 4/9] serial: qcom-geni: fix dma rx cancellation Johan Hovold
2024-10-09 14:51 ` [PATCH v3 5/9] serial: qcom-geni: fix receiver enable Johan Hovold
2024-10-10 22:36   ` Doug Anderson
2024-10-09 14:51 ` [PATCH v3 6/9] serial: qcom-geni: fix rx cancel dma status bit Johan Hovold
2024-10-09 14:51 ` Johan Hovold [this message]
2024-10-09 14:51 ` [PATCH v3 8/9] serial: qcom-geni: drop unused receive parameter Johan Hovold
2024-10-09 14:51 ` [PATCH v3 9/9] serial: qcom-geni: rename suspend functions Johan Hovold
2024-10-10 22:36   ` Doug Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241009145110.16847-8-johan+linaro@kernel.org \
    --to=johan+linaro@kernel.org \
    --cc=andersson@kernel.org \
    --cc=dianders@chromium.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=quic_msavaliy@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox