From: nicolas.bouchinet@clip-os.org
To: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Cc: nicolas.bouchinet@clip-os.org,
Nicolas Bouchinet <nicolas.bouchinet@ssi.gouv.fr>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Luis Chamberlain <mcgrof@kernel.org>, Kees Cook <kees@kernel.org>,
Joel Granados <j.granados@samsung.com>,
Andrew Morton <akpm@linux-foundation.org>,
Neil Horman <nhorman@tuxdriver.com>, Lin Feng <linf@wangsu.com>,
"Theodore Ts'o" <tytso@mit.edu>
Subject: [PATCH 2/3] sysctl: Fix underflow value setting risk in vm_table
Date: Tue, 12 Nov 2024 14:13:30 +0100 [thread overview]
Message-ID: <20241112131357.49582-3-nicolas.bouchinet@clip-os.org> (raw)
In-Reply-To: <20241112131357.49582-1-nicolas.bouchinet@clip-os.org>
From: Nicolas Bouchinet <nicolas.bouchinet@ssi.gouv.fr>
Commit 3b3376f222e3 ("sysctl.c: fix underflow value setting risk in
vm_table") fixes underflow value setting risk in vm_table but misses
vdso_enabled sysctl.
vdso_enabled sysctl is initialized with .extra1 value as SYSCTL_ZERO to
avoid negative value writes but the proc_handler is proc_dointvec and not
proc_dointvec_minmax and thus do not uses .extra1 and .extra2.
The following command thus works :
# echo -1 > /proc/sys/vm/vdso_enabled
This patch properly sets the proc_handler to proc_dointvec_minmax.
Fixes: 3b3376f222e3 ("sysctl.c: fix underflow value setting risk in vm_table")
Signed-off-by: Nicolas Bouchinet <nicolas.bouchinet@ssi.gouv.fr>
---
kernel/sysctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sysctl.c b/kernel/sysctl.c
index 79e6cb1d5c48f..37b1c1a760985 100644
--- a/kernel/sysctl.c
+++ b/kernel/sysctl.c
@@ -2194,7 +2194,7 @@ static struct ctl_table vm_table[] = {
.maxlen = sizeof(vdso_enabled),
#endif
.mode = 0644,
- .proc_handler = proc_dointvec,
+ .proc_handler = proc_dointvec_minmax,
.extra1 = SYSCTL_ZERO,
},
#endif
--
2.47.0
next prev parent reply other threads:[~2024-11-12 13:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 13:13 [PATCH 0/3] Fixes multiple sysctl proc_handler usage error nicolas.bouchinet
2024-11-12 13:13 ` [PATCH 1/3] coredump: Fixes core_pipe_limit sysctl proc_handler nicolas.bouchinet
2024-11-13 2:35 ` Lin Feng
2024-11-13 14:15 ` Nicolas Bouchinet
2024-11-14 1:34 ` Lin Feng
2024-11-14 14:25 ` Nicolas Bouchinet
2024-11-12 13:13 ` nicolas.bouchinet [this message]
2024-11-13 2:37 ` [PATCH 2/3] sysctl: Fix underflow value setting risk in vm_table Lin Feng
2024-11-12 13:13 ` [PATCH 3/3] tty: ldsic: fix tty_ldisc_autoload sysctl's proc_handler nicolas.bouchinet
2024-11-13 2:39 ` Lin Feng
2024-11-13 9:08 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241112131357.49582-3-nicolas.bouchinet@clip-os.org \
--to=nicolas.bouchinet@clip-os.org \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=j.granados@samsung.com \
--cc=jack@suse.cz \
--cc=jirislaby@kernel.org \
--cc=kees@kernel.org \
--cc=linf@wangsu.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=nicolas.bouchinet@ssi.gouv.fr \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox