Linux Serial subsystem development
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Andre Werner <andre.werner@systec-electronic.com>
Cc: jirislaby@kernel.org, hvilleneuve@dimonoff.com, andy@kernel.org,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	lech.perczak@camlingroup.com
Subject: Re: [PATCH v2] serial: sc16is7xx: Extend IRQ check for negative values
Date: Sat, 18 Jan 2025 08:34:07 +0100	[thread overview]
Message-ID: <2025011855-ashen-gigantic-f832@gregkh> (raw)
In-Reply-To: <20250117171822.775876-1-andre.werner@systec-electronic.com>

On Fri, Jan 17, 2025 at 06:18:22PM +0100, Andre Werner wrote:
> Fix the IRQ check to treat the negative values as No IRQ.
> 
> Signed-off-by: Andre Werner <andre.werner@systec-electronic.com>
> ---
> V2:
> There are no changes to the patch itself. The previous patch submission
> had a very weird structure within the discussion thread:
> https://lkml.org/lkml/2025/1/16/398
> This is simply a new thread opened for better handling.
> ---
>  drivers/tty/serial/sc16is7xx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
> index 7b51cdc274fd..560f45ed19ae 100644
> --- a/drivers/tty/serial/sc16is7xx.c
> +++ b/drivers/tty/serial/sc16is7xx.c
> @@ -1561,7 +1561,7 @@ int sc16is7xx_probe(struct device *dev, const struct sc16is7xx_devtype *devtype,
>  	/* Always ask for fixed clock rate from a property. */
>  	device_property_read_u32(dev, "clock-frequency", &uartclk);
>  
> -	s->polling = !!irq;
> +	s->polling = (irq <= 0);
>  	if (s->polling)
>  		dev_dbg(dev,
>  			"No interrupt pin definition, falling back to polling mode\n");
> -- 
> 2.48.0
> 
> 

What commit id does this "fix"?

thanks,

greg k-h

  reply	other threads:[~2025-01-18  7:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-17 17:18 [PATCH v2] serial: sc16is7xx: Extend IRQ check for negative values Andre Werner
2025-01-18  7:34 ` Greg KH [this message]
2025-01-18  8:41   ` Jiri Slaby
2025-01-18 19:28   ` [External Email] " Andre Werner
2025-01-19  6:48     ` Greg KH
2025-01-18 12:14 ` Maarten Brock
2025-01-18 17:20   ` [External Email] " Andre Werner
2025-01-19  8:00     ` Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025011855-ashen-gigantic-f832@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=andre.werner@systec-electronic.com \
    --cc=andy@kernel.org \
    --cc=hvilleneuve@dimonoff.com \
    --cc=jirislaby@kernel.org \
    --cc=lech.perczak@camlingroup.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox