public inbox for linux-serial@vger.kernel.org
 help / color / mirror / Atom feed
From: Douglas Anderson <dianders@chromium.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>,
	Daniel Thompson <danielt@kernel.org>
Cc: "Dr . David Alan Gilbert" <linux@treblig.org>,
	kgdb-bugreport@lists.sourceforge.net,
	Anton Vorontsov <anton.vorontsov@linaro.org>,
	Sumit Garg <sumit.garg@linaro.org>,
	linux-serial@vger.kernel.org,
	Douglas Anderson <dianders@chromium.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Arnd Bergmann <arnd@kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Hugo Villeneuve <hvilleneuve@dimonoff.com>,
	Jason Wessel <jason.wessel@windriver.com>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Niklas Schnelle <schnelle@linux.ibm.com>,
	Nir Lichtman <nir@lichtman.org>,
	Robert Marko <robert.marko@sartura.hr>,
	Thorsten Blum <thorsten.blum@linux.dev>,
	Yuran Pereira <yuran.pereira@hotmail.com>,
	Zheng Zengkai <zhengzengkai@huawei.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 0/3] kdb: Delete never used KGDB NMI code
Date: Wed, 29 Jan 2025 08:25:49 -0800	[thread overview]
Message-ID: <20250129162700.848018-1-dianders@chromium.org> (raw)

As pointed out in the review [1] of commit 39d0be87438a ("serial:
kgdb_nmi: Remove unused knock code"), it's not just the knock code
that's unused but a whole chunk of NMI-related code in KGDB.

Look back at the original series [2] and revert a few of the patches
that managed to land and had no other purpose. They've been in the
kernel for over 12 years and if nobody has used them during that time
then they won't get used.

I've validated things still compile just fine for me and I've tested
"allmodconfig" for a few different architectures. Hopefully I didn't
miss anything, but based on "grep" this is all just dead code.

I guess I'd expect this to land through Greg KH's tree, ideally Acked
by Daniel Thompson.

[1] https://lore.kernel.org/r/CAD=FV=VH5YWfTggGNt2KLoSPKqVTmWArEgccok3uFQ5BCA7cNw@mail.gmail.com
[2] https://lore.kernel.org/lkml/1348522080-32629-9-git-send-email-anton.vorontsov@linaro.org/


Douglas Anderson (3):
  Revert "tty/serial: Add kgdb_nmi driver"
  Revert "kdb: Implement disable_nmi command"
  Revert "kernel/debug: Mask KGDB NMI upon entry"

 drivers/tty/serial/Kconfig    |  19 ---
 drivers/tty/serial/Makefile   |   1 -
 drivers/tty/serial/kgdb_nmi.c | 280 ----------------------------------
 drivers/tty/serial/kgdboc.c   |   8 -
 include/linux/kgdb.h          |  11 --
 kernel/debug/debug_core.c     |  14 +-
 kernel/debug/kdb/kdb_main.c   |  37 -----
 7 files changed, 3 insertions(+), 367 deletions(-)
 delete mode 100644 drivers/tty/serial/kgdb_nmi.c

-- 
2.48.1.262.g85cc9f2d1e-goog


             reply	other threads:[~2025-01-29 16:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-29 16:25 Douglas Anderson [this message]
2025-01-29 16:25 ` [PATCH 1/3] Revert "tty/serial: Add kgdb_nmi driver" Douglas Anderson
2025-01-30  8:27   ` Andy Shevchenko
2025-01-30  8:32     ` Andy Shevchenko
2025-01-30 16:31       ` Andy Shevchenko
2025-01-29 16:25 ` [PATCH 2/3] Revert "kdb: Implement disable_nmi command" Douglas Anderson
2025-01-29 16:25 ` [PATCH 3/3] Revert "kernel/debug: Mask KGDB NMI upon entry" Douglas Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250129162700.848018-1-dianders@chromium.org \
    --to=dianders@chromium.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=anton.vorontsov@linaro.org \
    --cc=arnd@kernel.org \
    --cc=danielt@kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=gregkh@linuxfoundation.org \
    --cc=hvilleneuve@dimonoff.com \
    --cc=jason.wessel@windriver.com \
    --cc=jirislaby@kernel.org \
    --cc=kgdb-bugreport@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux@treblig.org \
    --cc=nicolas.ferre@microchip.com \
    --cc=nir@lichtman.org \
    --cc=robert.marko@sartura.hr \
    --cc=schnelle@linux.ibm.com \
    --cc=sumit.garg@linaro.org \
    --cc=thorsten.blum@linux.dev \
    --cc=yuran.pereira@hotmail.com \
    --cc=zhengzengkai@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox