public inbox for linux-serial@vger.kernel.org
 help / color / mirror / Atom feed
From: adamsimonelli@gmail.com
To: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jiri Slaby <jirislaby@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Adam Simonelli <adamsimonelli@gmail.com>
Subject: [PATCH v2 2/2] tty: Change order of ttynull to be loaded sooner.
Date: Sun, 16 Feb 2025 23:07:48 -0500	[thread overview]
Message-ID: <20250217040748.2017975-3-adamsimonelli@gmail.com> (raw)
In-Reply-To: <20250217040748.2017975-1-adamsimonelli@gmail.com>

From: Adam Simonelli <adamsimonelli@gmail.com>

If CONFIG_NULL_TTY_CONSOLE is enabled, and CONFIG_VT is disabled, ttynull
will become the default primary console device, based on the load order.
Users and distributions that are migrating away from CONFIG_VT will
benefit from this as /dev/console would not suddenly become /dev/ttyS0
which could otherwise cause some user space behavior changes, namely the
TCGETS ioctl failing, which causes libc's isatty() to incorrectly return
false when /dev/ttyS0 is disabled, and will prevent a device that is
connected to a user's /dev/ttyS0 to suddenly start getting kernel log
messages.

Signed-off-by: Adam Simonelli <adamsimonelli@gmail.com>
---
 drivers/tty/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/tty/Makefile b/drivers/tty/Makefile
index 07aca5184a55..03bb47e11e1c 100644
--- a/drivers/tty/Makefile
+++ b/drivers/tty/Makefile
@@ -11,6 +11,8 @@ obj-$(CONFIG_N_HDLC)		+= n_hdlc.o
 obj-$(CONFIG_N_GSM)		+= n_gsm.o
 
 obj-y				+= vt/
+obj-$(CONFIG_NULL_TTY)		+= ttynull.o
+
 obj-$(CONFIG_HVC_DRIVER)	+= hvc/
 obj-y				+= serial/
 obj-$(CONFIG_SERIAL_DEV_BUS)	+= serdev/
@@ -20,7 +22,6 @@ obj-$(CONFIG_AMIGA_BUILTIN_SERIAL) += amiserial.o
 obj-$(CONFIG_MOXA_INTELLIO)	+= moxa.o
 obj-$(CONFIG_MOXA_SMARTIO)	+= mxser.o
 obj-$(CONFIG_NOZOMI)		+= nozomi.o
-obj-$(CONFIG_NULL_TTY)	        += ttynull.o
 obj-$(CONFIG_SYNCLINK_GT)	+= synclink_gt.o
 obj-$(CONFIG_PPC_EPAPR_HV_BYTECHAN) += ehv_bytechan.o
 obj-$(CONFIG_GOLDFISH_TTY)	+= goldfish.o
-- 
2.45.2


  parent reply	other threads:[~2025-02-17  4:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-17  4:07 [PATCH v2 0/2] Optionally allow ttynull to be selected as a default console adamsimonelli
2025-02-17  4:07 ` [PATCH v2 1/2] ttynull: Add an option to allow ttynull to be used as a console device adamsimonelli
2025-02-19 14:00   ` Greg Kroah-Hartman
2025-02-23  5:08     ` Adam Simonelli
2025-02-17  4:07 ` adamsimonelli [this message]
2025-02-19 14:03   ` [PATCH v2 2/2] tty: Change order of ttynull to be loaded sooner Greg Kroah-Hartman
2025-02-23  4:56     ` Adam Simonelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250217040748.2017975-3-adamsimonelli@gmail.com \
    --to=adamsimonelli@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox