From: adamsimonelli@gmail.com
To: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Jiri Slaby <jirislaby@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Adam Simonelli <adamsimonelli@gmail.com>
Subject: [PATCH v4 1/2] ttynull: Add an option to allow ttynull to be used as a console device
Date: Sun, 23 Feb 2025 15:44:55 -0500 [thread overview]
Message-ID: <20250223204456.1913392-2-adamsimonelli@gmail.com> (raw)
In-Reply-To: <20250223204456.1913392-1-adamsimonelli@gmail.com>
From: Adam Simonelli <adamsimonelli@gmail.com>
The new config option, CONFIG_NULL_TTY_CONSOLE will allow ttynull to be
initialized by console_initcall() and selected as a possible console
device.
Signed-off-by: Adam Simonelli <adamsimonelli@gmail.com>
---
drivers/tty/Kconfig | 15 ++++++++++++++-
drivers/tty/ttynull.c | 20 +++++++++++++++++++-
2 files changed, 33 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/Kconfig b/drivers/tty/Kconfig
index 63a494d36a1f..b4afae8b0e74 100644
--- a/drivers/tty/Kconfig
+++ b/drivers/tty/Kconfig
@@ -383,7 +383,20 @@ config NULL_TTY
available or desired.
In order to use this driver, you should redirect the console to this
- TTY, or boot the kernel with console=ttynull.
+ TTY, boot the kernel with console=ttynull, or enable
+ CONFIG_NULL_TTY_CONSOLE.
+
+ If unsure, say N.
+
+config NULL_TTY_CONSOLE
+ bool "Support for console on ttynull"
+ depends on NULL_TTY=y && !VT_CONSOLE
+ help
+ Say Y here if you want the NULL TTY to be used as a /dev/console
+ device.
+
+ This is similar to CONFIG_VT_CONSOLE, but without the dependency on
+ CONFIG_VT. It uses the ttynull driver as the system console.
If unsure, say N.
diff --git a/drivers/tty/ttynull.c b/drivers/tty/ttynull.c
index 6b2f7208b564..ec3dd3fd41c0 100644
--- a/drivers/tty/ttynull.c
+++ b/drivers/tty/ttynull.c
@@ -57,6 +57,13 @@ static struct tty_driver *ttynull_device(struct console *c, int *index)
static struct console ttynull_console = {
.name = "ttynull",
.device = ttynull_device,
+
+ /*
+ * Match the index and flags from other boot consoles when CONFIG_NULL_TTY_CONSOLE is
+ * enabled, otherwise, use the default values for the index and flags.
+ */
+ .index = IS_ENABLED(CONFIG_NULL_TTY_CONSOLE) ? -1 : 0,
+ .flags = IS_ENABLED(CONFIG_NULL_TTY_CONSOLE) ? CON_PRINTBUFFER : 0,
};
static int __init ttynull_init(void)
@@ -90,11 +97,22 @@ static int __init ttynull_init(void)
}
ttynull_driver = driver;
- register_console(&ttynull_console);
+ if (!console_is_registered(&ttynull_console))
+ register_console(&ttynull_console);
return 0;
}
+#ifdef CONFIG_NULL_TTY_CONSOLE
+static int __init ttynull_register(void)
+{
+ if (!console_is_registered(&ttynull_console))
+ register_console(&ttynull_console);
+ return 0;
+}
+console_initcall(ttynull_register);
+#endif
+
static void __exit ttynull_exit(void)
{
unregister_console(&ttynull_console);
--
2.45.2
next prev parent reply other threads:[~2025-02-23 20:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-23 20:44 [PATCH v4 0/2] Optionally allow ttynull to be selected as a default console adamsimonelli
2025-02-23 20:44 ` adamsimonelli [this message]
2025-02-23 20:44 ` [PATCH v4 2/2] tty: Change order of ttynull to be linked sooner if enabled as a console adamsimonelli
2025-02-24 7:23 ` Greg Kroah-Hartman
2025-02-24 12:38 ` Adam Simonelli
2025-02-23 21:10 ` [PATCH v4 0/2] Optionally allow ttynull to be selected as a default console Andy Shevchenko
2025-02-24 0:23 ` Adam Simonelli
2025-02-24 7:19 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250223204456.1913392-2-adamsimonelli@gmail.com \
--to=adamsimonelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox