From: Greg KH <gregkh@linuxfoundation.org>
To: xiaopeitux@foxmail.com
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
xiaopei01 <xiaopei01@kylinos.cn>
Subject: Re: [PATCH] serial: 8250: Optimize port function assignment with generic macro
Date: Thu, 6 Mar 2025 08:05:33 +0100 [thread overview]
Message-ID: <2025030602-frays-profusely-0656@gregkh> (raw)
In-Reply-To: <tencent_50535E8627177335AEA311C5DC0A54609008@qq.com>
On Thu, Mar 06, 2025 at 11:00:32AM +0800, xiaopeitux@foxmail.com wrote:
> From: xiaopei01 <xiaopei01@kylinos.cn>
Sorry, as per the documentation we need a name, not just an email alias.
> Refactor repetitive conditional function pointer assignments using a
> generic macro ASSIGN_IF_EXIST. This consolidates 15+ conditional
> checks into a consistent pattern while maintaining type safety.
But why? Macros are a pain and hide what is happening here. Do you
think this makes the code more maintainable over time? Does it fix any
existing bugs?
thanks,
greg k-h
next prev parent reply other threads:[~2025-03-06 7:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 3:00 [PATCH] serial: 8250: Optimize port function assignment with generic macro xiaopeitux
2025-03-06 7:05 ` Greg KH [this message]
2025-03-07 2:12 ` Pei Xiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025030602-frays-profusely-0656@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=xiaopei01@kylinos.cn \
--cc=xiaopeitux@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox