* [PATCH] tty: caif: removed unused function debugfs_tx()
@ 2025-03-20 11:19 Simon Horman
2025-03-24 21:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Simon Horman @ 2025-03-20 11:19 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby
Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Nathan Chancellor, Nick Desaulniers, Bill Wendling,
Justin Stitt, linux-serial, netdev, linux-kernel, llvm
Remove debugfs_tx() which was added when the caif driver was added in
commit 9b27105b4a44 ("net-caif-driver: add CAIF serial driver (ldisc)")
but it has never been used.
Flagged by LLVM 19.1.7 W=1 builds.
Signed-off-by: Simon Horman <horms@kernel.org>
---
drivers/net/caif/caif_serial.c | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/drivers/net/caif/caif_serial.c b/drivers/net/caif/caif_serial.c
index ed3a589def6b..90ea3dc0fb10 100644
--- a/drivers/net/caif/caif_serial.c
+++ b/drivers/net/caif/caif_serial.c
@@ -126,15 +126,6 @@ static inline void debugfs_rx(struct ser_device *ser, const u8 *data, int size)
ser->rx_blob.data = ser->rx_data;
ser->rx_blob.size = size;
}
-
-static inline void debugfs_tx(struct ser_device *ser, const u8 *data, int size)
-{
- if (size > sizeof(ser->tx_data))
- size = sizeof(ser->tx_data);
- memcpy(ser->tx_data, data, size);
- ser->tx_blob.data = ser->tx_data;
- ser->tx_blob.size = size;
-}
#else
static inline void debugfs_init(struct ser_device *ser, struct tty_struct *tty)
{
@@ -151,11 +142,6 @@ static inline void update_tty_status(struct ser_device *ser)
static inline void debugfs_rx(struct ser_device *ser, const u8 *data, int size)
{
}
-
-static inline void debugfs_tx(struct ser_device *ser, const u8 *data, int size)
-{
-}
-
#endif
static void ldisc_receive(struct tty_struct *tty, const u8 *data,
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tty: caif: removed unused function debugfs_tx()
2025-03-20 11:19 [PATCH] tty: caif: removed unused function debugfs_tx() Simon Horman
@ 2025-03-24 21:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-03-24 21:40 UTC (permalink / raw)
To: Simon Horman
Cc: gregkh, jirislaby, andrew+netdev, davem, edumazet, kuba, pabeni,
nathan, ndesaulniers, morbo, justinstitt, linux-serial, netdev,
linux-kernel, llvm
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 20 Mar 2025 11:19:20 +0000 you wrote:
> Remove debugfs_tx() which was added when the caif driver was added in
> commit 9b27105b4a44 ("net-caif-driver: add CAIF serial driver (ldisc)")
> but it has never been used.
>
> Flagged by LLVM 19.1.7 W=1 builds.
>
> Signed-off-by: Simon Horman <horms@kernel.org>
>
> [...]
Here is the summary with links:
- tty: caif: removed unused function debugfs_tx()
https://git.kernel.org/netdev/net-next/c/29abdf662597
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-03-24 21:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-20 11:19 [PATCH] tty: caif: removed unused function debugfs_tx() Simon Horman
2025-03-24 21:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox