From: Greg KH <gregkh@linuxfoundation.org>
To: Thierry Bultel <thierry.bultel.yh@bp.renesas.com>
Cc: thierry.bultel@linatsea.fr, linux-renesas-soc@vger.kernel.org,
geert@linux-m68k.org, paul.barker.ct@bp.renesas.com,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v7 10/13] serial: sh-sci: Add support for RZ/T2H SCI
Date: Fri, 11 Apr 2025 16:57:25 +0200 [thread overview]
Message-ID: <2025041152-puzzling-clinking-e573@gregkh> (raw)
In-Reply-To: <20250403212919.1137670-11-thierry.bultel.yh@bp.renesas.com>
On Thu, Apr 03, 2025 at 11:29:12PM +0200, Thierry Bultel wrote:
> --- a/include/uapi/linux/serial_core.h
> +++ b/include/uapi/linux/serial_core.h
> @@ -231,6 +231,9 @@
> /* Sunplus UART */
> #define PORT_SUNPLUS 123
>
> +/* SH-SCI */
> +#define PORT_RSCI 124
Why do you need to tell userspace about this specific port? Is that a
hard requirement that your userspace tools require? If not, please
don't export this here.
thanks,
greg k-h
next prev parent reply other threads:[~2025-04-11 14:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250403212919.1137670-1-thierry.bultel.yh@bp.renesas.com>
2025-04-03 21:29 ` [PATCH v7 03/13] dt-bindings: serial: Add compatible for Renesas RZ/T2H SoC in sci Thierry Bultel
2025-04-17 14:04 ` Geert Uytterhoeven
2025-04-03 21:29 ` [PATCH v7 07/13] serial: sh-sci: Fix a comment about SCIFA Thierry Bultel
2025-04-03 21:29 ` [PATCH v7 08/13] serial: sh-sci: Introduced function pointers Thierry Bultel
2025-04-03 21:29 ` [PATCH v7 09/13] serial: sh-sci: Introduced sci_of_data Thierry Bultel
2025-04-03 21:29 ` [PATCH v7 10/13] serial: sh-sci: Add support for RZ/T2H SCI Thierry Bultel
2025-04-11 14:57 ` Greg KH [this message]
2025-04-14 7:54 ` Thierry Bultel
2025-04-14 8:58 ` Greg KH
2025-04-14 9:23 ` Thierry Bultel
2025-04-14 9:32 ` Greg KH
2025-04-14 14:07 ` Geert Uytterhoeven
2025-04-15 12:35 ` Greg KH
2025-04-17 12:53 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025041152-puzzling-clinking-e573@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=paul.barker.ct@bp.renesas.com \
--cc=thierry.bultel.yh@bp.renesas.com \
--cc=thierry.bultel@linatsea.fr \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox