From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4A1029D19; Mon, 14 Apr 2025 08:58:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744621114; cv=none; b=KaMWNJ0uCQ44dARcoVV6Wjc/pn+VroIKTy3wvwL7LIGgswVGeDT0KVDEYh/OTdeYz6/Usp7ri2ELUixGTHMNuz6llkI/XBqKm9GzKge8rxXsFsy4oIVkI3fg9VXFGO2FIqKOkFZqLSM5cFRvQG1gM2iFbqnFWJU70aps3TIGLTo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744621114; c=relaxed/simple; bh=cDCg7kZe9XYJRnj5EtD58kfDWWU0IFD44ydOOCFeVBI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=W4qZ3h+DJuI5Rn4cMLnYTVWXc7w75c+2lP1/MgRukeyobuOupx+VJYrxTSeJTeQjS/ZzrAG9f0BXAq3DhazLlTwoqGYPk8dGbGAly+z0XKDY/h23SkLMWsoKAheI7p1aWx7d+/aqdoEPdhJfbDi7VE7vAgGeiVK0cK8zJKnZRWs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=WW2mgQtK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="WW2mgQtK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DACEFC4CEE2; Mon, 14 Apr 2025 08:58:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1744621113; bh=cDCg7kZe9XYJRnj5EtD58kfDWWU0IFD44ydOOCFeVBI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WW2mgQtKJFst6/rbJhHuohhNDCSEOuBE4hUAGyMLos4Qm2f12/6ovmU9ScQdvO8hP tKZY6w0qaLg/xNO3LWuT9YYRq81e4CsQbA7ZEAj6JOpCZ4C/eqyan7ux46OLCu+OR7 sA6nhYjBHDJo2UGYpHw2PtOgxwmoGbdkEcctrViY= Date: Mon, 14 Apr 2025 10:58:29 +0200 From: Greg KH To: Thierry Bultel Cc: "thierry.bultel@linatsea.fr" , "linux-renesas-soc@vger.kernel.org" , "geert@linux-m68k.org" , Paul Barker , Wolfram Sang , "linux-kernel@vger.kernel.org" , "linux-serial@vger.kernel.org" Subject: Re: [PATCH v7 10/13] serial: sh-sci: Add support for RZ/T2H SCI Message-ID: <2025041456-legacy-craftwork-2d8b@gregkh> References: <20250403212919.1137670-1-thierry.bultel.yh@bp.renesas.com> <20250403212919.1137670-11-thierry.bultel.yh@bp.renesas.com> <2025041152-puzzling-clinking-e573@gregkh> Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Apr 14, 2025 at 07:54:12AM +0000, Thierry Bultel wrote: > Hi Greg, > > > -----Original Message----- > > From: Greg KH > > Sent: vendredi 11 avril 2025 16:57 > > To: Thierry Bultel > > Cc: thierry.bultel@linatsea.fr; linux-renesas-soc@vger.kernel.org; > > geert@linux-m68k.org; Paul Barker ; Wolfram > > Sang ; linux-kernel@vger.kernel.org; > > linux-serial@vger.kernel.org > > Subject: Re: [PATCH v7 10/13] serial: sh-sci: Add support for RZ/T2H SCI > > > > On Thu, Apr 03, 2025 at 11:29:12PM +0200, Thierry Bultel wrote: > > > --- a/include/uapi/linux/serial_core.h > > > +++ b/include/uapi/linux/serial_core.h > > > @@ -231,6 +231,9 @@ > > > /* Sunplus UART */ > > > #define PORT_SUNPLUS 123 > > > > > > +/* SH-SCI */ > > > +#define PORT_RSCI 124 > > > > Why do you need to tell userspace about this specific port? Is that a > > hard requirement that your userspace tools require? If not, please don't > > export this here. > > This point has been discussed with Geert and Wolfram. > We cannot use PORT_GENERIC for this IP, and adding the new type > is just keeping consistent with the sh-sci driver. But, why does userspace need to know this number? And why doesn't PORT_GENERIC work? thanks, greg k-h