From: Ryo Takakura <ryotkkr98@gmail.com>
To: john.ogness@linutronix.de
Cc: alex@ghiti.fr, aou@eecs.berkeley.edu, bigeasy@linutronix.de,
conor.dooley@microchip.com, gregkh@linuxfoundation.org,
jirislaby@kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-serial@vger.kernel.org,
palmer@dabbelt.com, paul.walmsley@sifive.com, pmladek@suse.com,
ryotkkr98@gmail.com, samuel.holland@sifive.com,
stable@vger.kernel.org, u.kleine-koenig@baylibre.com
Subject: Re: [PATCH v3] serial: sifive: lock port in startup()/shutdown() callbacks
Date: Tue, 15 Apr 2025 19:44:53 +0900 [thread overview]
Message-ID: <20250415104453.3690-1-ryotkkr98@gmail.com> (raw)
In-Reply-To: <84r01tooq9.fsf@jogness.linutronix.de>
On Tue, 15 Apr 2025 09:48:06 +0206, John Ogness wrote:
>On 2025-04-12, Ryo Takakura <ryotkkr98@gmail.com> wrote:
>> startup()/shutdown() callbacks access SIFIVE_SERIAL_IE_OFFS.
>> The register is also accessed from write() callback.
>>
>> If console were printing and startup()/shutdown() callback
>> gets called, its access to the register could be overwritten.
>>
>> Add port->lock to startup()/shutdown() callbacks to make sure
>> their access to SIFIVE_SERIAL_IE_OFFS is synchronized against
>> write() callback.
>>
>> Fixes: 45c054d0815b ("tty: serial: add driver for the SiFive UART")
>> Signed-off-by: Ryo Takakura <ryotkkr98@gmail.com>
>> Reviewed-by: Petr Mladek <pmladek@suse.com>
>
>Reviewed-by: John Ogness <john.ogness@linutronix.de>
I'll add for v4, Thank you John!
Sincerely,
Ryo Takakura
prev parent reply other threads:[~2025-04-15 10:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-12 0:18 [PATCH v3] serial: sifive: lock port in startup()/shutdown() callbacks Ryo Takakura
2025-04-15 7:42 ` John Ogness
2025-04-15 10:44 ` Ryo Takakura [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250415104453.3690-1-ryotkkr98@gmail.com \
--to=ryotkkr98@gmail.com \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=bigeasy@linutronix.de \
--cc=conor.dooley@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=pmladek@suse.com \
--cc=samuel.holland@sifive.com \
--cc=stable@vger.kernel.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox