From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B65E922D4CE; Fri, 9 May 2025 18:57:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746817048; cv=none; b=Vbo5r7E9apSVhySSjpPMCARfKwigQNxMj2BMpVWf8a63SrKQPaJBdZh0++wIkObfhlE5IM1vp3LI+Jb7gD6CMTmG3ivhI0td8NdDJPhF1C7Z9XKbkLZcVUvPUBabPgj9IziYaaTUj56kamwp/WZkcDZ+0zeUcdO8AwZY6Xx+KRI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746817048; c=relaxed/simple; bh=ZD0aaIrPowahZc0pDsydY92jojx2QtXYHD6gkSt51b4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dhlpvKPoVfr2tOr/BfmEsfptaHhIfwVgGd+BtD7vpFbVlyg4xEkYAhC/PA0p8BfHMjgR1GWUo3YpJSIbpzqlt2JyoNEHPMquA/DzavJ4TYTVPZ52b3p+qwFuCxFH2qleL9Z+txy0XdaIXGEkwznlusgBjwg5IoAbydagaxonAIs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QwpnNoBV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QwpnNoBV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 214F1C4CEE4; Fri, 9 May 2025 18:57:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746817048; bh=ZD0aaIrPowahZc0pDsydY92jojx2QtXYHD6gkSt51b4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QwpnNoBV/D0ppHEuYnXOrofAQpJczBo+sLjSMdl+k22vz51E910wsCTGGXTgSAZcZ 0tKLcP37Cq1SosGVbonoHobYbelMlARNcbQxxkRFl8yMmLi2KFMSvNO6+9u+0pGbA8 y3paOxtteNpewlJyy11KMEztu7RERWf+POeIlK3eQmYxlx6lBxZcV/y5qSlLV+1dx0 CRgVMpqqwUkURbu3pzBqy6m5JXZshQuPUiWflz13f5Fe/IsWojsRrtKPhD1njJoMz+ 7cSNiGscPqp3boQGNn+MZZEJnm7N3iR0fYXAMm6pv/aNaznBi0vvG+UGaSJpvHkm0P ShlOrK8Lo7F9A== Date: Fri, 9 May 2025 11:57:25 -0700 From: Kees Cook To: Joel Granados Cc: Luis Chamberlain , Petr Pavlu , Sami Tolvanen , Daniel Gomez , Peter Zijlstra , Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , "Paul E. McKenney" , Frederic Weisbecker , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Uladzislau Rezki , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Andrew Morton , "James E.J. Bottomley" , Helge Deller , Greg Kroah-Hartman , Jiri Slaby , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, rcu@vger.kernel.org, linux-mm@kvack.org, linux-parisc@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH 12/12] sysctl: Remove superfluous includes from kernel/sysctl.c Message-ID: <202505091157.C9A906F@keescook> References: <20250509-jag-mv_ctltables_iter2-v1-0-d0ad83f5f4c3@kernel.org> <20250509-jag-mv_ctltables_iter2-v1-12-d0ad83f5f4c3@kernel.org> Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250509-jag-mv_ctltables_iter2-v1-12-d0ad83f5f4c3@kernel.org> On Fri, May 09, 2025 at 02:54:16PM +0200, Joel Granados wrote: > Remove the following headers from the include list in sysctl.c. > > * These are removed as the related variables are no longer there. > =================== ==================== > Include Related Var > =================== ==================== > linux/kmod.h usermodehelper > asm/nmi.h nmi_watchdoc_enabled > asm/io.h io_delay_type > linux/pid.h pid_max_{,min,max} > linux/sched/sysctl.h sysctl_{sched_*,numa_*,timer_*} > linux/mount.h sysctl_mount_max > linux/reboot.h poweroff_cmd > linux/ratelimit.h {,printk_}ratelimit_state > linux/printk.h kptr_restrict > linux/security.h CONFIG_SECURITY_CAPABILITIES > linux/net.h net_table > linux/key.h key_sysctls > linux/nvs_fs.h acpi_video_flags > linux/acpi.h acpi_video_flags > linux/fs.h proc_nr_files > > * These are no longer needed as intermediate includes > ============== > Include > ============== > linux/filter.h > linux/binfmts.h > > Signed-off-by: Joel Granados This is very nice! :) Reviewed-by: Kees Cook -- Kees Cook