Re: [GIT PULL] TTY / Serial driver changes for 6.16-rc1

Linus Torvalds
2025-06-06T19:37:12Z

On Fri, 6 Jun 2025 at 01:39, Greg KH <gregkh@linuxfoundation.org> wrote:
>
> Here is the big set of tty and serial driver changes for 6.16-rc1.
> A little more churn than normal in this portion of the kernel for this
> development cycle, Jiri and Nicholas were busy with cleanups and reviews
> and fixes for the vt unicode handling logic which composed most of the
> overall work in here.

That series of "revert one series to re-apply the other" looks
absolutely disgusting.

I was close to deciding to not pull this at all, because some of it is
just inexcusably stupid. Lookie here:

git diff d066989a3d41..d066989a3d41^^
git log -2 --oneline d066989a3d41

and just stare in wonder at the pure unadulterated garbage.

Yes, the second series then improves on the first one the rest of the
way, but this should have been done better. And I don't mean just that
one truly pointless revert and reapply, but just "people should have
communicated that the patch series wasn't done"

I've pulled this, but I want to protest this kind of development
practice. The complete mindlessness of that "revert only to reapply"
really almost made me throw this out.

Linus