Re: [PATCH 26/33] serial: 8250: drop unused frac from serial8250_do_get_divisor()

Ilpo Järvinen
2025-06-11T13:04:49Z

[-- Attachment #1: Type: text/plain, Size: 1589 bytes --]

On Wed, 11 Jun 2025, Jiri Slaby (SUSE) wrote:

> 'frac' is not used in the generic implementation of get_divisor. Drop it
> from there. (Only some port->get_divisor() compute that and receive it
> then to port->set_divisor()).
>
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
> ---
> drivers/tty/serial/8250/8250_port.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c
> index 2af89038e50e..6363915a1787 100644
> --- a/drivers/tty/serial/8250/8250_port.c
> +++ b/drivers/tty/serial/8250/8250_port.c
> @@ -2481,9 +2481,7 @@ static void serial8250_flush_buffer(struct uart_port *port)
> serial8250_tx_dma_flush(up);
> }
>
> -static unsigned int serial8250_do_get_divisor(struct uart_port *port,
> - unsigned int baud,
> - unsigned int *frac)
> +static unsigned int serial8250_do_get_divisor(struct uart_port *port, unsigned int baud)
> {
> upf_t magic_multiplier = port->flags & UPF_MAGIC_MULTIPLIER;
> struct uart_8250_port *up = up_to_u8250p(port);
> @@ -2544,7 +2542,7 @@ static unsigned int serial8250_get_divisor(struct uart_port *port,
> if (port->get_divisor)
> return port->get_divisor(port, baud, frac);
>
> - return serial8250_do_get_divisor(port, baud, frac);
> + return serial8250_do_get_divisor(port, baud);
> }
>
> static unsigned char serial8250_compute_lcr(struct uart_8250_port *up, tcflag_t c_cflag)
>

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

--
i.