Re: [PATCH 23/33] serial: 8250: extract serial8250_set_efr()

Andy Shevchenko
2025-06-12T18:54:52Z

On Thu, Jun 12, 2025 at 12:01:29PM +0200, Jiri Slaby wrote:
> On 11. 06. 25, 14:58, Ilpo Järvinen wrote:
> > On Wed, 11 Jun 2025, Jiri Slaby (SUSE) wrote:

...

> > > + if (port->flags & UPF_EXAR_EFR)
> >
> > I wonder if it is possible to trigger this at all? Only 8250_exar.c sets
> > this flag and does not contain UART_CAP_EFR at all (nor uses
> > UPF_BOOT_AUTOCONF)??

The file indeed does not contain it, BUT it sets it implicitly (via port type).
So, this is not a dead code. Please, do not remove it.

If you find a good way how to move it to the 8250_exar.c, I will appreciate
that solution. Ideally 8250_port.c should be quirk-free module.

--
With Best Regards,
Andy Shevchenko