From: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
To: gregkh@linuxfoundation.org
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
"Jiri Slaby (SUSE)" <jirislaby@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: [PATCH v2 3/5] serial: 8250: rename lsr_TEMT, iir_NOINT to lowercase
Date: Tue, 24 Jun 2025 10:06:39 +0200 [thread overview]
Message-ID: <20250624080641.509959-4-jirislaby@kernel.org> (raw)
In-Reply-To: <20250624080641.509959-1-jirislaby@kernel.org>
There are already variables like 'iir_noint1' and 'iir_noint2'. Follow
the preexisting lowercase naming of variables. So s/lsr_TEMT/lsr_temt/
and 'iir_NOINT' likewise.
Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Suggested-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
drivers/tty/serial/8250/8250_port.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c
index 5bb0ca04da55..7eddcab318b4 100644
--- a/drivers/tty/serial/8250/8250_port.c
+++ b/drivers/tty/serial/8250/8250_port.c
@@ -2233,15 +2233,15 @@ static void serial8250_init_mctrl(struct uart_port *port)
static void serial8250_iir_txen_test(struct uart_port *port)
{
struct uart_8250_port *up = up_to_u8250p(port);
- bool lsr_TEMT, iir_NOINT;
+ bool lsr_temt, iir_noint;
if (port->quirks & UPQ_NO_TXEN_TEST)
return;
/* Do a quick test to see if we receive an interrupt when we enable the TX irq. */
serial_port_out(port, UART_IER, UART_IER_THRI);
- lsr_TEMT = serial_port_in(port, UART_LSR) & UART_LSR_TEMT;
- iir_NOINT = serial_port_in(port, UART_IIR) & UART_IIR_NO_INT;
+ lsr_temt = serial_port_in(port, UART_LSR) & UART_LSR_TEMT;
+ iir_noint = serial_port_in(port, UART_IIR) & UART_IIR_NO_INT;
serial_port_out(port, UART_IER, 0);
/*
@@ -2253,7 +2253,7 @@ static void serial8250_iir_txen_test(struct uart_port *port)
* variable. So, in case of UPQ_NO_TXEN_TEST, let's just don't test if we receive TX irq.
* This way, we'll never enable UART_BUG_TXEN.
*/
- if (lsr_TEMT && iir_NOINT) {
+ if (lsr_temt && iir_noint) {
if (!(up->bugs & UART_BUG_TXEN)) {
up->bugs |= UART_BUG_TXEN;
dev_dbg(port->dev, "enabling bad tx status workarounds\n");
--
2.50.0
next prev parent reply other threads:[~2025-06-24 8:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 8:06 [PATCH v2 0/5] tty: fixes on top of summer cleanup Jiri Slaby (SUSE)
2025-06-24 8:06 ` [PATCH v2 1/5] serial: 8250: extract serial8250_init_mctrl() Jiri Slaby (SUSE)
2025-06-24 11:02 ` Ilpo Järvinen
2025-06-24 11:15 ` Ilpo Järvinen
2025-06-25 5:59 ` Jiri Slaby
2025-06-24 14:10 ` Andy Shevchenko
2025-06-24 8:06 ` [PATCH v2 2/5] serial: 8250: extract serial8250_iir_txen_test() Jiri Slaby (SUSE)
2025-06-24 11:05 ` Ilpo Järvinen
2025-06-24 14:11 ` Andy Shevchenko
2025-06-24 8:06 ` Jiri Slaby (SUSE) [this message]
2025-06-24 11:15 ` [PATCH v2 3/5] serial: 8250: rename lsr_TEMT, iir_NOINT to lowercase Ilpo Järvinen
2025-06-24 14:12 ` Andy Shevchenko
2025-06-24 8:06 ` [PATCH v2 4/5] serial: 8250: document doubled "type == PORT_8250_CIR" check Jiri Slaby (SUSE)
2025-06-24 11:16 ` Ilpo Järvinen
2025-06-24 8:06 ` [PATCH v2 5/5] tty: fix tty_port_tty_*hangup() kernel-doc Jiri Slaby (SUSE)
2025-06-24 11:00 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250624080641.509959-4-jirislaby@kernel.org \
--to=jirislaby@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox