From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B57CC2701DF; Mon, 30 Jun 2025 12:49:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751287779; cv=none; b=DkQ7/0L0bxlvvzk3LZQiVlSAPCN9Sc7P2Swce7/nkWL/AK2k2OmOP/82oRk30+slNfsHBbtc+5bJ692Tyv1w3CA4tNKlKygkxlL7gkWl6u/vLhLe3GkhCJ/EvTqw94V7HrxfKOp3R29ZNBh5susXHZvE4bhxgpzO99bQyS8mMgQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751287779; c=relaxed/simple; bh=KtF4BRKLvG1l73SzUGVON88ZrJJsmmnn4uqKn3idkrU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Hsx5On1OLWVDGDnocrWNkkNuky0txDPdsXHdysKPqA61o38uFbkEg5VbHsaoNjf8al0pUgSQWxVqNCZZyQ9sOax0hUYxZcpho64iLn0tP5trUoymn6pJUdCb70rXv9LKiQQzNj7hhOcdGpDKNB+yEmCXGjo7kBo9292BZMlL/Y8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=revmr0zY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="revmr0zY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E678AC4CEF1; Mon, 30 Jun 2025 12:49:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1751287779; bh=KtF4BRKLvG1l73SzUGVON88ZrJJsmmnn4uqKn3idkrU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=revmr0zYtlzg+DeCEgI/3wLFgnKXwCNArgIWBZcr/KhfOobIncgMjF3tGSRhA+fXW 6vfzpBKJlc80jdu5/wPtsdL52l18cjOPUD3FrjH3XS6vIEE4scZUD//POLhqAikP9i USd2bA3XdoVlbdh1a9+5IgTl9RCZIXwgZD6fC7mQ= Date: Mon, 30 Jun 2025 14:49:36 +0200 From: Greg KH To: Thomas Fourier Cc: Jiri Slaby , Andy Shevchenko , Tomoya MORINAGA , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH v2] pch_uart: Fix dma_sync_sg_for_device() nents value Message-ID: <2025063023-trough-pyramid-3594@gregkh> References: <20250630121021.106643-2-fourier.thomas@gmail.com> Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250630121021.106643-2-fourier.thomas@gmail.com> On Mon, Jun 30, 2025 at 02:10:19PM +0200, Thomas Fourier wrote: > The dma_sync_sg_for_device() functions should be called with the same > nents as the dma_map_sg(), not the value the map function returned. > > Fixes: da3564ee027e ("pch_uart: add multi-scatter processing") > Signed-off-by: Thomas Fourier > --- > drivers/tty/serial/pch_uart.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/pch_uart.c b/drivers/tty/serial/pch_uart.c > index 508e8c6f01d4..884fefbfd5a1 100644 > --- a/drivers/tty/serial/pch_uart.c > +++ b/drivers/tty/serial/pch_uart.c > @@ -954,7 +954,7 @@ static unsigned int dma_handle_tx(struct eg20t_port *priv) > __func__); > return 0; > } > - dma_sync_sg_for_device(port->dev, priv->sg_tx_p, nent, DMA_TO_DEVICE); > + dma_sync_sg_for_device(port->dev, priv->sg_tx_p, num, DMA_TO_DEVICE); > priv->desc_tx = desc; > desc->callback = pch_dma_tx_complete; > desc->callback_param = priv; > -- > 2.43.0 > > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this. - You have marked a patch with a "Fixes:" tag for a commit that is in an older released kernel, yet you do not have a cc: stable line in the signed-off-by area at all, which means that the patch will not be applied to any older kernel releases. To properly fix this, please follow the documented rules in the Documentation/process/stable-kernel-rules.rst file for how to resolve this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot