From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Johan Hovold <johan@kernel.org>
Cc: Aidan Stewart <astewart@tektelic.com>,
Jiri Slaby <jirislaby@kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] serial: core: fix OF node leak
Date: Tue, 8 Jul 2025 17:26:10 +0200 [thread overview]
Message-ID: <2025070801-jelly-lyrically-0f65@gregkh> (raw)
In-Reply-To: <aG03-g3gVMgErPIA@hovoldconsulting.com>
On Tue, Jul 08, 2025 at 05:23:38PM +0200, Johan Hovold wrote:
> On Tue, Jul 08, 2025 at 01:37:45PM +0000, Aidan Stewart wrote:
> > On Tue, 2025-07-08 at 10:58 +0200, Johan Hovold wrote:
>
> > > Make sure to drop the OF node reference taken when initialising the
> > > control and port devices when the devices are later released.
> > >
> > > Fixes: d36f0e9a0002 ("serial: core: restore of_node information in
> > > sysfs")
> > > Cc: Aidan Stewart <astewart@tektelic.com>
> > > Signed-off-by: Johan Hovold <johan@kernel.org>
>
> > Thanks for the fix. I think this also needs to go into -stable, as the
> > previous changes have already landed there (6.12.36 and 6.15.5).
>
> I left out the stable tag on purpose since this leak should not cause
> trouble as, for example, these devices are typically registered at boot
> and never deregistered.
>
> It fixes an issue introduced in rc4 so it should preferably still go
> into 6.16-final, though.
Ok, will get this merged, thanks!
greg k-h
prev parent reply other threads:[~2025-07-08 15:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-08 8:58 [PATCH] serial: core: fix OF node leak Johan Hovold
2025-07-08 13:37 ` Aidan Stewart
2025-07-08 15:23 ` Johan Hovold
2025-07-08 15:26 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025070801-jelly-lyrically-0f65@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=astewart@tektelic.com \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox