public inbox for linux-serial@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Marwan Seliem <marwanmhks@gmail.com>
Cc: akpm@linux-foundation.org, jirislaby@kernel.org,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] tty: sysrq: Introduce compile-time crash-only mode
Date: Tue, 8 Jul 2025 10:05:24 +0200	[thread overview]
Message-ID: <2025070804-curler-hummus-8766@gregkh> (raw)
In-Reply-To: <20250707211650.12051-1-marwanmhks@gmail.com>

On Tue, Jul 08, 2025 at 12:16:50AM +0300, Marwan Seliem wrote:
> Let me clarify the security rationale and address your concerns.
> 
> > "security" involves crashing the system, so I fail to understand why one
> > is more "secure" than the other.
> 
> You're absolutely right that crash access itself requires careful consideration. 
> The security distinction we're making is between:
> 
> 1. Controlled Crash Access (our patch):
>    - Single, auditable code path (only sysrq-c)
>    - No runtime configuration possible
>    - No ancillary debug features that could leak information
> 
> 2. Full SysRq Access:
>    - ~60 command vectors to maintain/audit
>    - Runtime configuration complexity
>    - Features like memory/register dumps

One can make this argument for each of the sysrq options, but attempting
to make each one a config option is crazy.  We have chosen the "either
all or none" to make things simpler overall.

So attempting to maintain yet-another-configuration-option like this,
for the next 40+ years, is adding to our maintance burden for almost no
benifit that I can determine (hint, I still think it's crazy to allow a
system to crash but not the other things.)

So I can't accept this added complexity at this point in time, sorry.
If you can convince others that this really is worth the overhead
involved in it, please do so and come back with some more support.

thanks,

greg k-h

      reply	other threads:[~2025-07-08  8:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-07 15:19 [PATCH] tty: sysrq: Introduce compile-time crash-only mode Marwan Seliem
2025-06-09  7:48 ` Jiri Slaby
2025-06-11  6:33 ` Marwan Seliem
2025-06-19 11:20   ` Greg KH
2025-07-07 21:16     ` Marwan Seliem
2025-07-08  8:05       ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025070804-curler-hummus-8766@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=marwanmhks@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox