From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Jiri Slaby <jirislaby@kernel.org>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH] tty: serial: ip22zilog: Use platform device for probing
Date: Wed, 23 Jul 2025 14:02:43 +0200 [thread overview]
Message-ID: <2025072321-scorer-surfacing-1cdf@gregkh> (raw)
In-Reply-To: <20250723115823.76341-1-tsbogend@alpha.franken.de>
On Wed, Jul 23, 2025 at 01:58:23PM +0200, Thomas Bogendoerfer wrote:
> +static int __init sgi_zilog_devinit(void)
> +{
> + struct resource res;
> +
> + memset(&res, 0, sizeof(res));
> + res.start = HPC3_CHIP0_BASE + offsetof(struct hpc3_regs, rtcregs);
> + res.end = res.start + sizeof(hpc3c0->rtcregs) - 1;
> + res.flags = IORESOURCE_MEM;
> +
> + return platform_device_register(&zilog_device);
Odd function, why do you need "res" at all if you do not do anything
with it?
thanks,
greg k-h
next prev parent reply other threads:[~2025-07-23 12:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 11:58 [PATCH] tty: serial: ip22zilog: Use platform device for probing Thomas Bogendoerfer
2025-07-23 12:02 ` Greg Kroah-Hartman [this message]
2025-07-23 12:32 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025072321-scorer-surfacing-1cdf@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox