From: Greg KH <gregkh@linuxfoundation.org>
To: Anup Kulkarni <anup.kulkarni@oss.qualcomm.com>
Cc: jirislaby@kernel.org, johan+linaro@kernel.org,
dianders@chromium.org, quic_ptalari@quicinc.com,
bryan.odonoghue@linaro.org, quic_zongjian@quicinc.com,
quic_jseerapu@quicinc.com, quic_vdadhani@quicinc.com,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, mukesh.savaliya@oss.qualcomm.com,
viken.dadhaniya@oss.qualcomm.com, stable@vger.kernel.org
Subject: Re: [PATCH v1] tty: serial: qcom_geni_serial: Fix error handling for RS485 mode
Date: Wed, 17 Sep 2025 13:15:20 +0200 [thread overview]
Message-ID: <2025091701-glamorous-financial-b649@gregkh> (raw)
In-Reply-To: <20250916093957.4058328-1-anup.kulkarni@oss.qualcomm.com>
On Tue, Sep 16, 2025 at 03:09:57PM +0530, Anup Kulkarni wrote:
> If uart_get_rs485() fails, the driver returns without detaching
> the PM domain list.
>
> Fix the error handling path in uart_get_rs485_mode() to ensure the
> PM domain list is detached before exiting.
>
> Fixes: 86fa39dd6fb7 ("serial: qcom-geni: Enable Serial on SA8255p Qualcomm platforms")
> Cc: stable@vger.kernel.org
> Signed-off-by: Anup Kulkarni <anup.kulkarni@oss.qualcomm.com>
> ---
> drivers/tty/serial/qcom_geni_serial.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I've taken
https://lore.kernel.org/r/20250917010437.129912-2-krzysztof.kozlowski@linaro.org
instead, so this shouldn't be needed anymore.
thanks,
greg k-h
next prev parent reply other threads:[~2025-09-17 11:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-16 9:39 [PATCH v1] tty: serial: qcom_geni_serial: Fix error handling for RS485 mode Anup Kulkarni
2025-09-16 14:12 ` Bryan O'Donoghue
2025-09-17 11:15 ` Greg KH [this message]
2025-09-18 6:34 ` Anup Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025091701-glamorous-financial-b649@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=anup.kulkarni@oss.qualcomm.com \
--cc=bryan.odonoghue@linaro.org \
--cc=dianders@chromium.org \
--cc=jirislaby@kernel.org \
--cc=johan+linaro@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mukesh.savaliya@oss.qualcomm.com \
--cc=quic_jseerapu@quicinc.com \
--cc=quic_ptalari@quicinc.com \
--cc=quic_vdadhani@quicinc.com \
--cc=quic_zongjian@quicinc.com \
--cc=stable@vger.kernel.org \
--cc=viken.dadhaniya@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox