* [PATCH v1] tty: serial: qcom_geni_serial: Fix error handling for RS485 mode
@ 2025-09-16 9:39 Anup Kulkarni
2025-09-16 14:12 ` Bryan O'Donoghue
2025-09-17 11:15 ` Greg KH
0 siblings, 2 replies; 4+ messages in thread
From: Anup Kulkarni @ 2025-09-16 9:39 UTC (permalink / raw)
To: gregkh, jirislaby, johan+linaro, dianders, quic_ptalari,
bryan.odonoghue, quic_zongjian, anup.kulkarni, quic_jseerapu,
quic_vdadhani, linux-arm-msm, linux-kernel, linux-serial
Cc: mukesh.savaliya, viken.dadhaniya, stable
If uart_get_rs485() fails, the driver returns without detaching
the PM domain list.
Fix the error handling path in uart_get_rs485_mode() to ensure the
PM domain list is detached before exiting.
Fixes: 86fa39dd6fb7 ("serial: qcom-geni: Enable Serial on SA8255p Qualcomm platforms")
Cc: stable@vger.kernel.org
Signed-off-by: Anup Kulkarni <anup.kulkarni@oss.qualcomm.com>
---
drivers/tty/serial/qcom_geni_serial.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
index 9c7b1cea7cfe..0fc0f215b85c 100644
--- a/drivers/tty/serial/qcom_geni_serial.c
+++ b/drivers/tty/serial/qcom_geni_serial.c
@@ -1928,7 +1928,7 @@ static int qcom_geni_serial_probe(struct platform_device *pdev)
ret = uart_get_rs485_mode(uport);
if (ret)
- return ret;
+ goto error;
devm_pm_runtime_enable(port->se.dev);
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v1] tty: serial: qcom_geni_serial: Fix error handling for RS485 mode
2025-09-16 9:39 [PATCH v1] tty: serial: qcom_geni_serial: Fix error handling for RS485 mode Anup Kulkarni
@ 2025-09-16 14:12 ` Bryan O'Donoghue
2025-09-17 11:15 ` Greg KH
1 sibling, 0 replies; 4+ messages in thread
From: Bryan O'Donoghue @ 2025-09-16 14:12 UTC (permalink / raw)
To: Anup Kulkarni, gregkh, jirislaby, johan+linaro, dianders,
quic_ptalari, quic_zongjian, quic_jseerapu, quic_vdadhani,
linux-arm-msm, linux-kernel, linux-serial
Cc: mukesh.savaliya, viken.dadhaniya, stable
On 16/09/2025 10:39, Anup Kulkarni wrote:
> If uart_get_rs485() fails, the driver returns without detaching
> the PM domain list.
>
> Fix the error handling path in uart_get_rs485_mode() to ensure the
> PM domain list is detached before exiting.
>
> Fixes: 86fa39dd6fb7 ("serial: qcom-geni: Enable Serial on SA8255p Qualcomm platforms")
> Cc: stable@vger.kernel.org
> Signed-off-by: Anup Kulkarni <anup.kulkarni@oss.qualcomm.com>
> ---
> drivers/tty/serial/qcom_geni_serial.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
> index 9c7b1cea7cfe..0fc0f215b85c 100644
> --- a/drivers/tty/serial/qcom_geni_serial.c
> +++ b/drivers/tty/serial/qcom_geni_serial.c
> @@ -1928,7 +1928,7 @@ static int qcom_geni_serial_probe(struct platform_device *pdev)
>
> ret = uart_get_rs485_mode(uport);
> if (ret)
> - return ret;
> + goto error;
>
> devm_pm_runtime_enable(port->se.dev);
>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v1] tty: serial: qcom_geni_serial: Fix error handling for RS485 mode
2025-09-16 9:39 [PATCH v1] tty: serial: qcom_geni_serial: Fix error handling for RS485 mode Anup Kulkarni
2025-09-16 14:12 ` Bryan O'Donoghue
@ 2025-09-17 11:15 ` Greg KH
2025-09-18 6:34 ` Anup Kulkarni
1 sibling, 1 reply; 4+ messages in thread
From: Greg KH @ 2025-09-17 11:15 UTC (permalink / raw)
To: Anup Kulkarni
Cc: jirislaby, johan+linaro, dianders, quic_ptalari, bryan.odonoghue,
quic_zongjian, quic_jseerapu, quic_vdadhani, linux-arm-msm,
linux-kernel, linux-serial, mukesh.savaliya, viken.dadhaniya,
stable
On Tue, Sep 16, 2025 at 03:09:57PM +0530, Anup Kulkarni wrote:
> If uart_get_rs485() fails, the driver returns without detaching
> the PM domain list.
>
> Fix the error handling path in uart_get_rs485_mode() to ensure the
> PM domain list is detached before exiting.
>
> Fixes: 86fa39dd6fb7 ("serial: qcom-geni: Enable Serial on SA8255p Qualcomm platforms")
> Cc: stable@vger.kernel.org
> Signed-off-by: Anup Kulkarni <anup.kulkarni@oss.qualcomm.com>
> ---
> drivers/tty/serial/qcom_geni_serial.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I've taken
https://lore.kernel.org/r/20250917010437.129912-2-krzysztof.kozlowski@linaro.org
instead, so this shouldn't be needed anymore.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v1] tty: serial: qcom_geni_serial: Fix error handling for RS485 mode
2025-09-17 11:15 ` Greg KH
@ 2025-09-18 6:34 ` Anup Kulkarni
0 siblings, 0 replies; 4+ messages in thread
From: Anup Kulkarni @ 2025-09-18 6:34 UTC (permalink / raw)
To: Greg KH
Cc: jirislaby, johan+linaro, dianders, quic_ptalari, bryan.odonoghue,
quic_zongjian, quic_jseerapu, quic_vdadhani, linux-arm-msm,
linux-kernel, linux-serial, mukesh.savaliya, viken.dadhaniya,
stable
On Wed, Sep 17, 2025 at 4:45 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Tue, Sep 16, 2025 at 03:09:57PM +0530, Anup Kulkarni wrote:
> > If uart_get_rs485() fails, the driver returns without detaching
> > the PM domain list.
> >
> > Fix the error handling path in uart_get_rs485_mode() to ensure the
> > PM domain list is detached before exiting.
> >
> > Fixes: 86fa39dd6fb7 ("serial: qcom-geni: Enable Serial on SA8255p Qualcomm platforms")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Anup Kulkarni <anup.kulkarni@oss.qualcomm.com>
> > ---
> > drivers/tty/serial/qcom_geni_serial.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> I've taken
> https://lore.kernel.org/r/20250917010437.129912-2-krzysztof.kozlowski@linaro.org
> instead, so this shouldn't be needed anymore.
>
Agree. It's not required now.
> thanks,
>
> greg k-h
thanks,
Anup
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-09-18 6:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-16 9:39 [PATCH v1] tty: serial: qcom_geni_serial: Fix error handling for RS485 mode Anup Kulkarni
2025-09-16 14:12 ` Bryan O'Donoghue
2025-09-17 11:15 ` Greg KH
2025-09-18 6:34 ` Anup Kulkarni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox