Linux Serial subsystem development
 help / color / mirror / Atom feed
From: Sherry Sun <sherry.sun@nxp.com>
To: gregkh@linuxfoundation.org, jirislaby@kernel.org,
	shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com, shenwei.wang@nxp.com
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
	imx@lists.linux.dev
Subject: [PATCH 1/2] tty: serial: imx: Only configure the wake register when device is set as wakeup source
Date: Tue, 23 Sep 2025 11:16:12 +0800	[thread overview]
Message-ID: <20250923031613.2448073-2-sherry.sun@nxp.com> (raw)
In-Reply-To: <20250923031613.2448073-1-sherry.sun@nxp.com>

Currently, imx uart defaults to enabling the wake related registers for
all uart devices. However, it is unnecessary for those devices not
configured as wakeup source, so add device_may_wakeup() check before
configuring the uart wake related registers.

Fixes: db1a9b55004c ("tty: serial: imx: Allow UART to be a source for wakeup")
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
 drivers/tty/serial/imx.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
index 500dfc009d03..4ddfc89816bf 100644
--- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c
@@ -2697,7 +2697,22 @@ static void imx_uart_save_context(struct imx_port *sport)
 /* called with irq off */
 static void imx_uart_enable_wakeup(struct imx_port *sport, bool on)
 {
+	struct tty_port *port = &sport->port.state->port;
+	struct tty_struct *tty;
+	struct device *tty_dev;
 	u32 ucr3;
+	bool may_wake;
+
+	tty = tty_port_tty_get(port);
+	if (tty) {
+		tty_dev = tty->dev;
+		may_wake = tty_dev && device_may_wakeup(tty_dev);
+		tty_kref_put(tty);
+	}
+
+	/* only configure the wake register when device set as wakeup source */
+	if (!may_wake)
+		return;
 
 	uart_port_lock_irq(&sport->port);
 
-- 
2.34.1


  reply	other threads:[~2025-09-23  3:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-23  3:16 [PATCH 0/2] tty: serial: imx: improve the imx uart wakeup function Sherry Sun
2025-09-23  3:16 ` Sherry Sun [this message]
2025-09-23  8:32   ` [PATCH 1/2] tty: serial: imx: Only configure the wake register when device is set as wakeup source Peng Fan
2025-09-23  7:36     ` Sherry Sun
2025-09-23 16:42   ` kernel test robot
2025-09-23  3:16 ` [PATCH 2/2] tty: serial: imx: Add missing wakeup event reporting Sherry Sun
2025-09-23 17:35   ` kernel test robot
2025-09-23 18:27   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250923031613.2448073-2-sherry.sun@nxp.com \
    --to=sherry.sun@nxp.com \
    --cc=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=imx@lists.linux.dev \
    --cc=jirislaby@kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=shenwei.wang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox