On Tue, Oct 28, 2025 at 07:39:41PM +0000, Biju Das wrote: > Hi Conor Dooley, > > > -----Original Message----- > > From: Conor Dooley > > Sent: 28 October 2025 19:28 > > Subject: Re: [PATCH 02/19] dt-bindings: serial: rsci: Drop "uart-has-rtscts: false" > > > > On Mon, Oct 27, 2025 at 03:45:49PM +0000, Biju Das wrote: > > > Drop "uart-has-rtscts: false" from binding as the IP support hardware > > > flow control. > > > > Why is it being removed, rather than only being required for the existing devices? It's not clear to > > me that the comment about the IP supporting flow control excludes the integration on these particular > > devices from somehow having flow control disabled. > > It was a mistake previously as the driver does not implement hardware flow control and > is excluded in device tree. > > Actually, the RSCI IP on all SoCs supports hardware flow control. > If a channel need flow control it can make use of the property uart-has-rtscts; > That is the reason for removing hardware flow control disabled property("uart-has-rtscts: false") Could you update the commit message to be clear that that's the case? Just something like "as the IP supports hardware flow control on all SoCs". With that, Acked-by: Conor Dooley Cheers, Conor. pw-bot: changes-requested