From: Hugo Villeneuve <hugo@hugovil.com>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>,
Nam Cao <namcao@linutronix.de>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Biju Das <biju.das.au@gmail.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 06/19] serial: sh-sci: Drop extra line
Date: Tue, 28 Oct 2025 10:35:13 -0400 [thread overview]
Message-ID: <20251028103513.a107e9765c73926ceca8454a@hugovil.com> (raw)
In-Reply-To: <20251027154615.115759-7-biju.das.jz@bp.renesas.com>
Hi Biju,
On Mon, 27 Oct 2025 15:45:53 +0000
Biju Das <biju.das.jz@bp.renesas.com> wrote:
> Shorten the number lines in sci_init_clocks() by fitting the error
> message within an 80-character length limit.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> drivers/tty/serial/sh-sci.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
> index b33894d0273b..699c39b81c4b 100644
> --- a/drivers/tty/serial/sh-sci.c
> +++ b/drivers/tty/serial/sh-sci.c
> @@ -3009,8 +3009,7 @@ static int sci_init_clocks(struct sci_port *sci_port, struct device *dev)
>
> if (!clk && sci_port->type == SCI_PORT_RSCI &&
> (i == SCI_FCK || i == SCI_BRG_INT)) {
> - return dev_err_probe(dev, -ENODEV,
> - "failed to get %s\n",
> + return dev_err_probe(dev, -ENODEV, "failed to get %s\n",
> name);
You can even put it all on one line with the now 100 columns limit.
> }
>
> --
> 2.43.0
>
>
--
Hugo Villeneuve
next prev parent reply other threads:[~2025-10-28 14:35 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 15:45 [PATCH 00/19] Add RZ/G3E RSCI support Biju Das
2025-10-27 15:45 ` [PATCH 02/19] dt-bindings: serial: rsci: Drop "uart-has-rtscts: false" Biju Das
2025-10-28 19:28 ` Conor Dooley
2025-10-28 19:39 ` Biju Das
2025-10-28 19:50 ` Conor Dooley
2025-10-28 20:27 ` Biju Das
2025-10-27 15:45 ` [PATCH 03/19] dt-bindings: serial: renesas,rsci: Document RZ/G3E support Biju Das
2025-10-28 19:30 ` Conor Dooley
2025-10-28 19:41 ` Biju Das
2025-10-28 19:51 ` Conor Dooley
2025-10-28 20:26 ` Biju Das
2025-10-29 17:20 ` Conor Dooley
2025-10-27 15:45 ` [PATCH 04/19] serial: sh-sci: Fix deadlock during RSCI FIFO overrun error Biju Das
2025-10-28 8:40 ` Greg Kroah-Hartman
2025-10-28 9:08 ` Biju Das
2025-10-27 15:45 ` [PATCH 05/19] serial: rsci: Drop rsci_clear_CFC() Biju Das
2025-10-27 15:45 ` [PATCH 06/19] serial: sh-sci: Drop extra line Biju Das
2025-10-28 14:35 ` Hugo Villeneuve [this message]
2025-10-30 14:43 ` Biju Das
2025-10-27 15:45 ` [PATCH 07/19] serial: rsci: Drop unused macro DCR Biju Das
2025-10-27 15:45 ` [PATCH 08/19] serial: rsci: Drop unused TDR register Biju Das
2025-10-27 15:45 ` [PATCH 09/19] serial: sh-sci: Use devm_reset_control_array_get_exclusive() Biju Das
2025-10-27 15:45 ` [PATCH 10/19] serial: sh-sci: Add RSCI_PORT_{SCI,SCIF} port IDs Biju Das
2025-10-27 15:45 ` [PATCH 11/19] serial: sh-sci: Add sci_is_rsci_type() Biju Das
2025-10-27 15:45 ` [PATCH 12/19] serial: sh-sci: Add support for RZ/G3E RSCI clks Biju Das
2025-10-28 14:51 ` Hugo Villeneuve
2025-10-28 15:08 ` Biju Das
2025-10-28 15:37 ` Hugo Villeneuve
2025-10-27 15:46 ` [PATCH 13/19] serial: sh-sci: Make sci_scbrr_calc() public Biju Das
2025-10-27 15:46 ` [PATCH 14/19] serial: sh-sci: Add finish_console_write() callback Biju Das
2025-10-27 15:46 ` [PATCH 15/19] serial: sh-sci: Add support for RZ/G3E RSCI SCIF Biju Das
2025-10-28 15:22 ` Hugo Villeneuve
2025-10-27 15:46 ` [PATCH 16/19] serial: sh-sci: Add support for RZ/G3E RSCI SCI Biju Das
2025-10-28 8:41 ` [PATCH 00/19] Add RZ/G3E RSCI support Greg Kroah-Hartman
2025-10-28 9:12 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251028103513.a107e9765c73926ceca8454a@hugovil.com \
--to=hugo@hugovil.com \
--cc=biju.das.au@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=namcao@linutronix.de \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox