From: Greg KH <gregkh@linuxfoundation.org>
To: "Magne.Bruno" <Magne.Bruno@addi-data.com>
Cc: "jirislaby@kernel.org" <jirislaby@kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>
Subject: Re: [PATCH 001/001] serial: add support of CPCI cards
Date: Mon, 10 Nov 2025 09:59:10 +0900 [thread overview]
Message-ID: <2025111009-whoopee-avalanche-002e@gregkh> (raw)
In-Reply-To: <AS2PR08MB9917F98E256B2C7A97EA5BFAAAC1A@AS2PR08MB9917.eurprd08.prod.outlook.com>
On Sun, Nov 09, 2025 at 07:03:14AM +0000, Magne.Bruno wrote:
> Dear Greg,
>
> If, we do not add those Ids to the serial driver, the driver will not manage automatically our 4 CPCI cards, like it does for PCI and PCIe cards.
I agree, sorry, what I was asking specifically was:
> > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index
> > 92ffc4373f6d..221a83d4e1ed 100644
> > --- a/include/linux/pci_ids.h
> > +++ b/include/linux/pci_ids.h
This file, look at the top of it. You shouldn't be adding ids to this
file unless they are shared across multiple drivers. Just add the
#defines instead to the .c file where they are referenced. So this
patch should just be touching one file, not two.
thanks,
greg k-h
next prev parent reply other threads:[~2025-11-10 0:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-08 21:46 [PATCH 001/001] serial: add support of CPCI cards Magne Bruno
2025-11-09 0:50 ` Greg KH
2025-11-09 7:03 ` Magne.Bruno
2025-11-10 0:59 ` Greg KH [this message]
2025-11-10 16:23 ` Magne.Bruno
-- strict thread matches above, loose matches on Subject: below --
2025-11-10 16:24 Magne Bruno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025111009-whoopee-avalanche-002e@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Magne.Bruno@addi-data.com \
--cc=jirislaby@kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox