Re: [PATCH v1 1/1] serial: core: Restore sysfs fwnode information

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Thu, Nov 27, 2025 at 05:36:50PM +0100, Andy Shevchenko wrote:
> The change that restores sysfs fwnode information does it only for OF cases.
> Update the fix to cover all possible types of fwnodes.
> 
> Fixes: d36f0e9a0002 ("serial: core: restore of_node information in sysfs")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/tty/serial/serial_base_bus.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/tty/serial/serial_base_bus.c b/drivers/tty/serial/serial_base_bus.c
> index 22749ab0428a..8e891984cdc0 100644
> --- a/drivers/tty/serial/serial_base_bus.c
> +++ b/drivers/tty/serial/serial_base_bus.c
> @@ -13,7 +13,7 @@
>  #include <linux/device.h>
>  #include <linux/idr.h>
>  #include <linux/module.h>
> -#include <linux/of.h>
> +#include <linux/property.h>
>  #include <linux/serial_core.h>
>  #include <linux/slab.h>
>  #include <linux/spinlock.h>
> @@ -60,6 +60,7 @@ void serial_base_driver_unregister(struct device_driver *driver)
>  	driver_unregister(driver);
>  }
>  
> +/* On failure the caller must put device @dev with put_device() */
>  static int serial_base_device_init(struct uart_port *port,
>  				   struct device *dev,
>  				   struct device *parent_dev,
> @@ -73,7 +74,8 @@ static int serial_base_device_init(struct uart_port *port,
>  	dev->parent = parent_dev;
>  	dev->bus = &serial_base_bus_type;
>  	dev->release = release;
> -	device_set_of_node_from_dev(dev, parent_dev);
> +
> +	device_set_node(dev, fwnode_handle_get(dev_fwnode(parent_dev)));
>  
>  	if (!serial_base_initialized) {
>  		dev_dbg(port->dev, "uart_add_one_port() called before arch_initcall()?\n");
> @@ -94,7 +96,7 @@ static void serial_base_ctrl_release(struct device *dev)
>  {
>  	struct serial_ctrl_device *ctrl_dev = to_serial_base_ctrl_device(dev);
>  
> -	of_node_put(dev->of_node);
> +	fwnode_handle_put(dev_fwnode(dev));
>  	kfree(ctrl_dev);
>  }
>  
> @@ -142,7 +144,7 @@ static void serial_base_port_release(struct device *dev)
>  {
>  	struct serial_port_device *port_dev = to_serial_base_port_device(dev);
>  
> -	of_node_put(dev->of_node);
> +	fwnode_handle_put(dev_fwnode(dev));
>  	kfree(port_dev);
>  }
>  
> -- 
> 2.50.1
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You have marked a patch with a "Fixes:" tag for a commit that is in an
  older released kernel, yet you do not have a cc: stable line in the
  signed-off-by area at all, which means that the patch will not be
  applied to any older kernel releases.  To properly fix this, please
  follow the documented rules in the
  Documentation/process/stable-kernel-rules.rst file for how to resolve
  this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot