public inbox for linux-serial@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Cosmin Tanislav <demonsingur@gmail.com>
Cc: Alexander Stein <alexander.stein@ew.tq-group.com>,
	Jiri Slaby <jirislaby@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH 1/1] serial: core: Fix serial device initialization
Date: Sun, 21 Dec 2025 10:21:01 +0100	[thread overview]
Message-ID: <2025122145-reward-stroller-4fdd@gregkh> (raw)
In-Reply-To: <1ab9287b-bab4-48de-a6fc-88b5f0797e6c@gmail.com>

On Sun, Dec 21, 2025 at 10:59:52AM +0200, Cosmin Tanislav wrote:
> 
> 
> On 12/21/25 10:40 AM, Greg Kroah-Hartman wrote:
> > On Fri, Dec 19, 2025 at 04:28:12PM +0100, Alexander Stein wrote:
> > > During restoring sysfs fwnode information the information of_node_reused
> > > was dropped. This was previously set by device_set_of_node_from_dev().
> > > Add it back manually
> > > 
> > > Fixes: 24ec03cc5512 ("serial: core: Restore sysfs fwnode information")
> > > Suggested-by: Cosmin Tanislav <demonsingur@gmail.com>
> > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > > ---
> > >   drivers/tty/serial/serial_base_bus.c | 1 +
> > >   1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/drivers/tty/serial/serial_base_bus.c b/drivers/tty/serial/serial_base_bus.c
> > > index 8e891984cdc0d..1e1ad28d83fcf 100644
> > > --- a/drivers/tty/serial/serial_base_bus.c
> > > +++ b/drivers/tty/serial/serial_base_bus.c
> > > @@ -74,6 +74,7 @@ static int serial_base_device_init(struct uart_port *port,
> > >   	dev->parent = parent_dev;
> > >   	dev->bus = &serial_base_bus_type;
> > >   	dev->release = release;
> > > +	dev->of_node_reused = true;
> > >   	device_set_node(dev, fwnode_handle_get(dev_fwnode(parent_dev)));
> > > -- 
> > > 2.43.0
> > > 
> > > 
> > 
> > Can I get some confirmation from people that this resolves the issue, or
> > should I just revert the original problem commit instead and wait for a
> > tested new version?
> > 
> 
> Hi Greg. I confirmed that this fixes the issue before I suggested the
> fix. :D

Great, can you respond with a tested-by?

  reply	other threads:[~2025-12-21  9:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-19 15:28 [PATCH 1/1] serial: core: Fix serial device initialization Alexander Stein
2025-12-21  8:40 ` Greg Kroah-Hartman
2025-12-21  8:59   ` Cosmin Tanislav
2025-12-21  9:21     ` Greg Kroah-Hartman [this message]
2025-12-22 11:03   ` Marek Szyprowski
2025-12-21  9:46 ` Cosmin Tanislav
2025-12-23 10:43 ` Michael Walle
2025-12-24  7:10 ` Jingyi Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025122145-reward-stroller-4fdd@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=demonsingur@gmail.com \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox