public inbox for linux-serial@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Rong Zhang <rongrong@oss.cipunited.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	 Jiri Slaby <jirislaby@kernel.org>, Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Huacai Chen <chenhuacai@loongson.cn>,
	 Jiaxun Yang <jiaxun.yang@flygoat.com>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	 linux-mips@vger.kernel.org, devicetree@vger.kernel.org,
	Yao Zi <me@ziyao.cc>,  Icenowy Zheng <uwu@icenowy.me>,
	Rong Zhang <i@rong.moe>
Subject: Re: [PATCH 3/3] MIPS: dts: loongson64g-package: Switch to Loongson UART driver
Date: Sun, 15 Mar 2026 10:08:57 +0100	[thread overview]
Message-ID: <20260315-towering-black-oxpecker-1dc2e0@quoll> (raw)
In-Reply-To: <20260314234143.651298-4-rongrong@oss.cipunited.com>

On Sun, Mar 15, 2026 at 07:41:43AM +0800, Rong Zhang wrote:
> Loongson64g is Loongson 3A4000, whose UART controller is compatible with
> Loongson 2K1500, which is NS16550A-compatible with an additional
> fractional frequency divisor register.
> 
> Update the compatible strings to reflect this, so that 3A4000 can
> benefit from the fractional frequency divisor provided by loongson-uart.
> This is required on some devices, otherwise their UART can't work at
> some high baud rates, e.g., 115200.
> 
> Tested on Loongson-LS3A4000-7A1000-NUC-SE with a 25MHz UART clock.
> Without fractional frequency divisor, the actual baud rate was 111607
> (25MHz / 16 / 14, measured value: 111545) and some USB-to-UART
> converters couldn't work with it at all. With fractional frequency
> divisor, the measured baud rate becomes 115207, which is quite accurate.
> 
> Signed-off-by: Rong Zhang <rongrong@oss.cipunited.com>
> ---
>  arch/mips/boot/dts/loongson/loongson64g-package.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

DTS should be sent separately, don't mix independent patches targetting
serial tree.

Best regards,
Krzysztof


      reply	other threads:[~2026-03-15  9:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-14 23:41 [PATCH 0/3] MIPS: dts: loongson64g-package: Switch to Loongson UART driver Rong Zhang
2026-03-14 23:41 ` [PATCH 1/3] dt-bindings: serial: 8250: Add Loongson 3A4000 uart compatible Rong Zhang
2026-03-15  9:09   ` Krzysztof Kozlowski
2026-03-14 23:41 ` [PATCH 2/3] serial: 8250: loongson: Enable building on MIPS Loongson64 Rong Zhang
2026-03-14 23:41 ` [PATCH 3/3] MIPS: dts: loongson64g-package: Switch to Loongson UART driver Rong Zhang
2026-03-15  9:08   ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260315-towering-black-oxpecker-1dc2e0@quoll \
    --to=krzk@kernel.org \
    --cc=chenhuacai@loongson.cn \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=i@rong.moe \
    --cc=jiaxun.yang@flygoat.com \
    --cc=jirislaby@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=me@ziyao.cc \
    --cc=robh@kernel.org \
    --cc=rongrong@oss.cipunited.com \
    --cc=tsbogend@alpha.franken.de \
    --cc=uwu@icenowy.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox