public inbox for linux-serial@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: yuhaocheng035@gmail.com
Cc: Jiri Slaby <jirislaby@kernel.org>,
	Nicolas Pitre <npitre@baylibre.com>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	Calixte Pernot <calixte.pernot@grenoble-inp.org>
Subject: Re: [PATCH] tty: vt: Fix slab-out-of-bounds write in do_con_write
Date: Sat, 21 Mar 2026 07:37:31 +0100	[thread overview]
Message-ID: <2026032158-trickily-absentee-74ee@gregkh> (raw)
In-Reply-To: <2026032123-earplugs-stunning-0c6f@gregkh>

On Sat, Mar 21, 2026 at 07:32:34AM +0100, Greg Kroah-Hartman wrote:
> > +			return -1;
> 
> Do not make up error numbers :(

Ah, I see this value being returned elsewhere in this function,
nevermind, my fault.  But really, it should be an -ERROR value, not just
-1.

thanks,

greg k-h

  reply	other threads:[~2026-03-21  6:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-21  6:23 [PATCH] tty: vt: Fix slab-out-of-bounds write in do_con_write yuhaocheng035
2026-03-21  6:32 ` Greg Kroah-Hartman
2026-03-21  6:37   ` Greg Kroah-Hartman [this message]
2026-03-22  7:32   ` Haocheng Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026032158-trickily-absentee-74ee@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=calixte.pernot@grenoble-inp.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=npitre@baylibre.com \
    --cc=yuhaocheng035@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox