Re: [PATCH 04/10] lib/fonts: Clean up Makefile

Thomas Zimmermann
2026-04-01T07:58:22Z

Hi

Am 01.04.26 um 09:48 schrieb Geert Uytterhoeven:
> Hi Thomas,
>
> On Fri, 27 Mar 2026 at 14:05, Thomas Zimmermann <tzimmermann@suse.de> wrote:
>> Simplify the Makefile. Drop font-obj-y and sort the fonts by dictionary
>> order. Done in preparation for supporting optional font rotation.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Thanks for your patch, which is now commit 3f90ea78f5fe9495
> ("lib/fonts: Clean up Makefile") in fbdev/for-next.
>
>> --- a/lib/fonts/Makefile
>> +++ b/lib/fonts/Makefile
>> @@ -1,23 +1,22 @@
>> # SPDX-License-Identifier: GPL-2.0
>> # Font handling
>>
>> -font-objs := fonts.o
>> +font-y := fonts.o
>>
>> -font-objs-$(CONFIG_FONT_SUN8x16) += font_sun8x16.o
>> -font-objs-$(CONFIG_FONT_SUN12x22) += font_sun12x22.o
>> -font-objs-$(CONFIG_FONT_8x8) += font_8x8.o
>> -font-objs-$(CONFIG_FONT_8x16) += font_8x16.o
>> -font-objs-$(CONFIG_FONT_6x11) += font_6x11.o
>> -font-objs-$(CONFIG_FONT_7x14) += font_7x14.o
>> -font-objs-$(CONFIG_FONT_10x18) += font_10x18.o
>> -font-objs-$(CONFIG_FONT_PEARL_8x8) += font_pearl_8x8.o
>> -font-objs-$(CONFIG_FONT_ACORN_8x8) += font_acorn_8x8.o
>> -font-objs-$(CONFIG_FONT_MINI_4x6) += font_mini_4x6.o
>> -font-objs-$(CONFIG_FONT_6x10) += font_6x10.o
>> -font-objs-$(CONFIG_FONT_TER10x18) += font_ter10x18.o
>> -font-objs-$(CONFIG_FONT_TER16x32) += font_ter16x32.o
>> -font-objs-$(CONFIG_FONT_6x8) += font_6x8.o
>> +# Built-in fonts
>> +font-$(CONFIG_FONT_10x18) += font_10x18.o
>> +font-$(CONFIG_FONT_6x10) += font_6x10.o
>> +font-$(CONFIG_FONT_6x11) += font_6x11.o
>> +font-$(CONFIG_FONT_6x8) += font_6x8.o
>> +font-$(CONFIG_FONT_7x14) += font_7x14.o
>> +font-$(CONFIG_FONT_8x16) += font_8x16.o
>> +font-$(CONFIG_FONT_8x8) += font_8x8.o
> Please sort the anonymous entries by increasing font size.

Makes sense. I'll also leave a comment on the sorting order.

Best regards
Thomas

>
>> +font-$(CONFIG_FONT_ACORN_8x8) += font_acorn_8x8.o
>> +font-$(CONFIG_FONT_MINI_4x6) += font_mini_4x6.o
>> +font-$(CONFIG_FONT_PEARL_8x8) += font_pearl_8x8.o
>> +font-$(CONFIG_FONT_SUN12x22) += font_sun12x22.o
>> +font-$(CONFIG_FONT_SUN8x16) += font_sun8x16.o
>> +font-$(CONFIG_FONT_TER10x18) += font_ter10x18.o
>> +font-$(CONFIG_FONT_TER16x32) += font_ter16x32.o
>>
>> -font-objs += $(font-objs-y)
>> -
>> -obj-$(CONFIG_FONT_SUPPORT) += font.o
>> +obj-$(CONFIG_FONT_SUPPORT) += font.o
> Gr{oetje,eeting}s,
>
> Geert
>

--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)