From: Guangshuo Li <lgs201920130244@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Guangshuo Li <lgs201920130244@gmail.com>,
Russell King <rmk@dyn-67.arm.linux.org.uk>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Cc: stable@vger.kernel.org
Subject: [PATCH] serial: 8250_accent: fix reference leak on failed device registration
Date: Thu, 16 Apr 2026 02:34:36 +0800 [thread overview]
Message-ID: <20260415183436.3763871-1-lgs201920130244@gmail.com> (raw)
When platform_device_register() fails in accent_init(), the embedded
struct device in accent_device has already been initialized by
device_initialize(), but the failure path returns the error without
dropping the device reference for the current platform device:
accent_init()
-> platform_device_register(&accent_device)
-> device_initialize(&accent_device.dev)
-> setup_pdev_dma_masks(&accent_device)
-> platform_device_add(&accent_device)
This leads to a reference leak when platform_device_register() fails.
Fix this by calling platform_device_put() before returning the error.
The issue was identified by a static analysis tool I developed and
confirmed by manual review.
Fixes: ec9f47cd6a14c ("[PATCH] Serial: Split 8250 port table")
Cc: stable@vger.kernel.org
Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>
---
drivers/tty/serial/8250/8250_accent.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/serial/8250/8250_accent.c b/drivers/tty/serial/8250/8250_accent.c
index 1691f1a57f89..e9cf40268c0e 100644
--- a/drivers/tty/serial/8250/8250_accent.c
+++ b/drivers/tty/serial/8250/8250_accent.c
@@ -25,7 +25,13 @@ static struct platform_device accent_device = {
static int __init accent_init(void)
{
- return platform_device_register(&accent_device);
+ int ret;
+
+ ret = platform_device_register(&accent_device);
+ if (ret)
+ platform_device_put(&accent_device);
+
+ return ret;
}
module_init(accent_init);
--
2.43.0
next reply other threads:[~2026-04-15 18:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 18:34 Guangshuo Li [this message]
2026-04-16 6:13 ` [PATCH] serial: 8250_accent: fix reference leak on failed device registration Jiri Slaby
2026-04-16 9:37 ` Guangshuo Li
2026-04-16 10:23 ` Guangshuo Li
2026-04-16 10:43 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260415183436.3763871-1-lgs201920130244@gmail.com \
--to=lgs201920130244@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rmk@dyn-67.arm.linux.org.uk \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox