Linux Serial subsystem development
 help / color / mirror / Atom feed
From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Matthias Feser <mfe@kbsgmbhfr.onmicrosoft.com>
Cc: Moteen Shah <m-shah@ti.com>,
	"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	"jirislaby@kernel.org" <jirislaby@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"k-willis@ti.com" <k-willis@ti.com>,
	"msp@baylibre.com" <msp@baylibre.com>,
	"andriy.shevchenko@linux.intel.com"
	<andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v4] serial: 8250_omap: clear rx_running on zero-length DMA completes
Date: Sat, 23 May 2026 07:47:12 +0200	[thread overview]
Message-ID: <2026052316-drown-guidable-0e7f@gregkh> (raw)
In-Reply-To: <BE3P281MB55154E3A7B5BF556B6020ADFEE0F2@BE3P281MB5515.DEUP281.PROD.OUTLOOK.COM>

On Fri, May 22, 2026 at 12:37:25PM +0000, Matthias Feser wrote:
> On AM33xx RX DMA only triggers when the FIFO reaches the
> configured threshold (typically 48 bytes). For smaller bursts
> no DMA request is issued and the FIFO is drained by RX timeout.
> 
> In this case __dma_rx_do_complete() can legitimately see count == 0.
> 
> The current code exits early in this case and does not clear
> dma->rx_running, leaving the DMA state inconsistent. This can
> prevent RX DMA from restarting and may cause
> omap_8250_rx_dma_flush() to fail, marking DMA as broken.
> 
> Fix this by clearing dma->rx_running once the DMA transfer has
> completed or been terminated, even if no data was transferred.
> 
> Signed-off-by: Matthias Feser <mfe@KBSgmbhfr.onmicrosoft.com>
> Reviewed-by: Moteen Shah <m-shah@ti.com>
> ---
> Changes in v4:
> - Add blank line before dma->rx_running as suggested

Please properly start a new thread, don't have this patch be in reply to
another one, the "Re:" in it is a bit odd, don't you think?

And what commit id does this fix?  Should it be backported to stable
kernels?  If so, how far back?

thanks,

greg k-h

  reply	other threads:[~2026-05-23  5:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-21 13:30 [PATCH] serial: 8250_omap: clear rx_running on zero-length DMA completes Matthias Feser
2026-05-22  5:40 ` Moteen Shah
2026-05-22  8:24   ` [PATCH v2] " Matthias Feser
2026-05-22  8:25     ` Moteen Shah
2026-05-22  8:28     ` Moteen Shah
2026-05-22  9:02       ` AW: [PATCH v3] " Matthias Feser
2026-05-22 10:18         ` Moteen Shah
2026-05-22 12:37           ` [PATCH v4] " Matthias Feser
2026-05-23  5:47             ` gregkh [this message]
2026-05-22  8:46     ` [PATCH v2] " gregkh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026052316-drown-guidable-0e7f@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=jirislaby@kernel.org \
    --cc=k-willis@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=m-shah@ti.com \
    --cc=mfe@kbsgmbhfr.onmicrosoft.com \
    --cc=msp@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox