From: Weiming Shi <bestswngs@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Xiang Mei <xmei5@asu.edu>
Subject: [PATCH] tty: serial: core: fix NULL pointer deref in uart_resume_port()
Date: Mon, 8 Jun 2026 09:52:17 -0700 [thread overview]
Message-ID: <20260608165223.70148-1-bestswngs@gmail.com> (raw)
uart_resume_port() looks up the tty device child with device_find_child()
and passes the result straight to device_may_wakeup(). device_find_child()
returns NULL when the port has no matching tty device child, and
device_may_wakeup() dereferences dev->power.can_wakeup, so a NULL tty_dev
faults. uart_suspend_port() already guards the same call with
"tty_dev && device_may_wakeup(tty_dev)"; the resume path does not.
Oops: general protection fault, probably for non-canonical address
KASAN: null-ptr-deref in range [0x148-0x14f]
RIP: 0010:uart_resume_port (pm_wakeup.h:84 serial_core.c:2477)
serial_pnp_resume (8250/8250_pnp.c:522)
pnp_bus_resume (drivers/pnp/driver.c:234)
Mirror the NULL guard from uart_suspend_port(). put_device(tty_dev)
already tolerates a NULL argument, so only the device_may_wakeup() call
needs the check; the non-NULL path is unchanged.
Fixes: b3b708fa2780 ("wake up from a serial port")
Reported-by: Xiang Mei <xmei5@asu.edu>
Assisted-by: Claude:claude-opus-4-8
Signed-off-by: Weiming Shi <bestswngs@gmail.com>
---
drivers/tty/serial/serial_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
index 89cebdd278410..7dd3ec3dea438 100644
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -2373,7 +2373,7 @@ int uart_resume_port(struct uart_driver *drv, struct uart_port *uport)
guard(mutex)(&port->mutex);
tty_dev = device_find_child(&uport->port_dev->dev, &match, serial_match_port);
- if (!uport->suspended && device_may_wakeup(tty_dev)) {
+ if (!uport->suspended && tty_dev && device_may_wakeup(tty_dev)) {
if (irqd_is_wakeup_set(irq_get_irq_data((uport->irq))))
disable_irq_wake(uport->irq);
put_device(tty_dev);
--
2.43.0
reply other threads:[~2026-06-08 16:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260608165223.70148-1-bestswngs@gmail.com \
--to=bestswngs@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=xmei5@asu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox