Linux Serial subsystem development
 help / color / mirror / Atom feed
From: Jing Wu <realwujing@gmail.com>
To: gregkh@linuxfoundation.org
Cc: jirislaby@kernel.org, avorontsov@ru.mvista.com, alan@redhat.com,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	wangzhaolong@fnnas.com
Subject: Re: [PATCH v4] serial: 8250: fix use-after-free in IRQ chain handling
Date: Tue, 23 Jun 2026 22:32:20 +0800	[thread overview]
Message-ID: <20260623143220.432877-1-realwujing@gmail.com> (raw)
In-Reply-To: <2026061213-blinker-portable-a198@gregkh>

From: Qiliang Yuan <realwujing@gmail.com>

On Fri, Jun 12, 2026 at 11:49:51AM +0200, Greg Kroah-Hartman wrote:
> What real systems causes this to happen?  How are you triggering this
> warning to happen?  How was this tested?

The original report is Bugzilla #221579 from Wang Zhaolong.  The bug
triggers on systems with multiple 8250 serial ports sharing an IRQ
(e.g. NAS-like devices).  It can be reproduced by probing/removing
8250 serial ports that share an IRQ.  Wang confirmed off-list that v3
fixes the reproducer on his setup.

> Shouldn't the function be marked as requiring this lock to be held?
> Just putting in this lockdep_assert will not catch the static analysis
> tools :(

Agreed, will add __must_hold(&hash_mutex) in v5.

Thanks,
Qiliang

      reply	other threads:[~2026-06-23 14:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-29  8:23 [PATCH v4] serial: 8250: fix use-after-free in IRQ chain handling Qiliang Yuan
2026-06-12  9:49 ` Greg Kroah-Hartman
2026-06-23 14:32   ` Jing Wu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260623143220.432877-1-realwujing@gmail.com \
    --to=realwujing@gmail.com \
    --cc=alan@redhat.com \
    --cc=avorontsov@ru.mvista.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=wangzhaolong@fnnas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox