From: Jing Wu <realwujing@gmail.com>
To: jirislaby@kernel.org
Cc: gregkh@linuxfoundation.org, avorontsov@ru.mvista.com,
alan@redhat.com, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, wangzhaolong@fnnas.com
Subject: Re: [PATCH v5] serial: 8250: fix use-after-free in IRQ chain handling
Date: Tue, 7 Jul 2026 21:53:08 +0800 [thread overview]
Message-ID: <20260707135308.1404824-1-realwujing@gmail.com> (raw)
In-Reply-To: <80f44ace-9231-4b4e-9e47-cbe49b3e2d3e@kernel.org>
From: Qiliang Yuan <realwujing@gmail.com>
On Thu, Jun 25, 2026 at 06:38:35AM +0200, Jiri Slaby wrote:
> I don't follow, the function now looks like this:
> ...
> What am I missing?
You're right, nothing is missing. The function releases hash_mutex at
every return path, which is exactly what guard(mutex) provides. And
i->lock is only held across the list manipulation, before request_irq(),
so scoped_guard(spinlock_irq, &i->lock) also fits.
I'll send a v6 keeping the guard style.
Thanks,
Qiliang
prev parent reply other threads:[~2026-07-07 13:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-24 1:21 [PATCH v5] serial: 8250: fix use-after-free in IRQ chain handling Qiliang Yuan
2026-06-24 3:31 ` Jiri Slaby
2026-06-24 8:43 ` Jing Wu
2026-06-25 4:38 ` Jiri Slaby
2026-07-07 13:53 ` Jing Wu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260707135308.1404824-1-realwujing@gmail.com \
--to=realwujing@gmail.com \
--cc=alan@redhat.com \
--cc=avorontsov@ru.mvista.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=wangzhaolong@fnnas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox